Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested functions and arguments in user error messaging #418

Open
bms63 opened this issue Apr 3, 2024 · 3 comments
Open

Suggested functions and arguments in user error messaging #418

bms63 opened this issue Apr 3, 2024 · 3 comments

Comments

@bms63
Copy link
Collaborator

bms63 commented Apr 3, 2024

@ddsjoberg , what do you think? Should this be the next task for the error messaging group?

@bundfussr sounds great! I like the suggested messaging. We can also capture the error from filter() and print our custom message followed by the message that filter() throws as well.

(Re-reading and seeing that is exactly what you suggested haha)

Originally posted by @ddsjoberg in pharmaverse/admiral#2391 (comment)

@bms63
Copy link
Collaborator Author

bms63 commented Apr 3, 2024

Sorry - just trying to keep on the radar. Poorly filled out issue right now! :)

@bundfussr
Copy link
Collaborator

I am not sure if this is an issue for admiraldev. I would expect that most of the updates are in admiral (unless we implement a helper function like process_set_value_to() in admiraldev).

@ddsjoberg
Copy link
Collaborator

I was thinking we could have a function like safe_filter() that captures any errors from dplyr::filter() and gives the appropriate error message? But that really depends on how many different contexts we're trying to cover...anyway, let's discuss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants