Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do we need to update the DESCRIPTION file with remotes so they get the latest and greatest from the helper packages? #341

Closed
bms63 opened this issue Oct 19, 2023 · 0 comments
Closed

do we need to update the DESCRIPTION file with remotes so they get the latest and greatest from the helper packages? #341

bms63 opened this issue Oct 19, 2023 · 0 comments

Comments

@bms63
Copy link
Collaborator

bms63 commented Oct 19, 2023 

          > > do we need to update the DESCRIPTION file with remotes so they get the latest and greatest from the helper packages?

@bms63 if we make an update that depends on a dev version of the helper packages, then we should add Remotes: to the DESCRIPTION. Otherwise, we should just keep it as is.

Could we document this somewhere?
Would it harm to add Remotes: even if currently the devel version does not depend on devel versions of dependencies? Adding and removing Remotes: looks cumbersome to me and most likely we will forget it.

Originally posted by @bundfussr in pharmaverse/admiral#2171 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
admiral (sdtm/adam, dev, ci, template, core)
Status: Archive
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bms63