From be6cb71832fc5eb05e51929edf47bf3d9afdc615 Mon Sep 17 00:00:00 2001 From: Zelos Zhu Date: Tue, 3 Oct 2023 19:43:00 +0000 Subject: [PATCH 1/3] feat: #2147 one solution but proceed with caution --- tests/testthat/test-derive_param_computed.R | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/tests/testthat/test-derive_param_computed.R b/tests/testthat/test-derive_param_computed.R index 3a56d901bb..165bddfeec 100644 --- a/tests/testthat/test-derive_param_computed.R +++ b/tests/testthat/test-derive_param_computed.R @@ -343,15 +343,7 @@ test_that("derive_param_computed Test 8: no new observations if a constant param AVALU = "kg/m2" ) ), - regexp = paste( - paste( - "The input dataset does not contain any observations fullfiling the filter", - "condition (NULL) for the parameter codes (PARAMCD) `HEIGHT`" - ), - "No new observations were added.", - sep = "\n" - ), - fixed = TRUE + regexp = "The input dataset does not contain any observations fullfiling the filter" ) expect_dfs_equal( From e12a166d3938302f12dd3731678518617bfec206 Mon Sep 17 00:00:00 2001 From: Zelos Zhu Date: Wed, 4 Oct 2023 14:00:35 +0000 Subject: [PATCH 2/3] description uplevel and news blurb --- DESCRIPTION | 2 +- NEWS.md | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/DESCRIPTION b/DESCRIPTION index 5c1291ece0..5e0280144a 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,7 +1,7 @@ Package: admiral Type: Package Title: ADaM in R Asset Library -Version: 0.12.1 +Version: 0.12.2 Authors@R: c( person("Ben", "Straub", email = "ben.x.straub@gsk.com", role = c("aut", "cre")), person("Stefan", "Bundfuss", role = "aut"), diff --git a/NEWS.md b/NEWS.md index 9f48559ee0..8da921cb28 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,3 +1,7 @@ +# admiral 0.12.2 + +- A unit test for `derive_param_computed()` was modified in anticipation of major user-facing changes to R version 4.4 (#2147) + # admiral 0.12.1 - `derive_extreme_records()` no longer fails if `dataset_add` is specified and a From 9e3f450587794c8bc415032091d99391794d9dfd Mon Sep 17 00:00:00 2001 From: Zelos Zhu Date: Wed, 4 Oct 2023 15:32:31 +0000 Subject: [PATCH 3/3] pass links? --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 1ed1d6ac3b..f6d68d759b 100644 --- a/README.md +++ b/README.md @@ -45,7 +45,7 @@ Phases: | Q4-2023 | December 4th | December 11th | | | [{pharmaversesdtm}](https://pharmaverse.github.io/pharmaversesdtm/main/) | [{admiralonco}](https://pharmaverse.github.io/admiralonco/main/) | | | [{admiraldev}](https://pharmaverse.github.io/admiraldev/main/) | [{admiralophtha}](https://pharmaverse.github.io/admiralophtha/main/) | -| | [{admiral}](https://pharmaverse.github.io/admiral/main/) | | +| | [{admiral}](https://pharmaverse.github.io/admiral) | | The `{admiral}` Q4-2023 release will officially be `{admiral}`'s version 1.0.0 release, where we commit to increased package maturity and pivot towards focusing on maintenance rather than new content. This does not mean that there will never be any new content in `{admiral}`, rather it means we will be more mindful about introducing new functionality and/or breaking changes. The release schedule in 2024 and onward will also shift to twice-yearly, rather than quarterly, so that our users have ample time to react to any new content and changes that do make it onto `{admiral}`.