You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
> I'm ready to merge this into `main`. @pharmaverse/admiral any last thoughts or concerns?
Sorry for the late reply. I was off because the 3rd October is a bank holiday here.
I think the PR shouldn't have been merged. There are a lot of unresolved issues:
The create_*() scripts don't run.
The scripts include code which is never run.
data-raw/admiral_adlb.R was added to the repo but it is never used.
The data-backup folder should be removed because it is not necessary but increases the size of the repo (and the scripts do not update the backup anyway).
Sorry for the late reply. I was off because the 3rd October is a bank holiday here.
I think the PR shouldn't have been merged. There are a lot of unresolved issues:
create_*()
scripts don't run.data-raw/admiral_adlb.R
was added to the repo but it is never used.data-backup
folder should be removed because it is not necessary but increases the size of the repo (and the scripts do not update the backup anyway).@bms63 , how should we move on?
Originally posted by @bundfussr in #2494 (comment)
The text was updated successfully, but these errors were encountered: