Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Issues: data-raw/data Round 2 #2526

Closed
bms63 opened this issue Oct 7, 2024 · 1 comment · Fixed by #2539
Closed

General Issues: data-raw/data Round 2 #2526

bms63 opened this issue Oct 7, 2024 · 1 comment · Fixed by #2539
Assignees

Comments

@bms63
Copy link
Collaborator

bms63 commented Oct 7, 2024

          > I'm ready to merge this into `main`. @pharmaverse/admiral any last thoughts or concerns?

Sorry for the late reply. I was off because the 3rd October is a bank holiday here.

I think the PR shouldn't have been merged. There are a lot of unresolved issues:

  • The create_*() scripts don't run.
  • The scripts include code which is never run.
  • data-raw/admiral_adlb.R was added to the repo but it is never used.
  • The data-backup folder should be removed because it is not necessary but increases the size of the repo (and the scripts do not update the backup anyway).
  • ...

@bms63 , how should we move on?

Originally posted by @bundfussr in #2494 (comment)

@jimrothstein
Copy link
Collaborator

jimrothstein commented Oct 7, 2024

@bms63 I will get this done later today.

@bms63 - before I make a mess, any suggestion? (Thx)

Git branch ?
(1) Start a new local branch (#2526) and new PR?
(2) OR, continue with same local branch (#2427), now merged?

@jimrothstein jimrothstein linked a pull request Oct 23, 2024 that will close this issue
15 tasks
bms63 added a commit that referenced this issue Oct 25, 2024
…eries code and some fun things were found!! /s
@bms63 bms63 closed this as completed in b44fd3d Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants