Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Bring cheatsheet into alignment with 1.1.0 and 1.2.0 changes #2458

Open
8 of 9 tasks
bms63 opened this issue Jun 6, 2024 · 11 comments · May be fixed by #2600
Open
8 of 9 tasks

Documentation: Bring cheatsheet into alignment with 1.1.0 and 1.2.0 changes #2458

bms63 opened this issue Jun 6, 2024 · 11 comments · May be fixed by #2600
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@bms63
Copy link
Collaborator

bms63 commented Jun 6, 2024

Please select a category the issue is focused on?

User Guides

Let us know where something needs a refresh or put your idea here!

We need to align the cheatsheet to admiral 1.1.0. As far as I can tell only derive_var_trtemfl() needs a slight update for new argument. However, there could be others!

Current Cheat Sheet
https://github.com/pharmaverse/admiral/blob/main/inst/cheatsheet/admiral_cheatsheet.pdf

Use this powerpoint to modify Cheat Sheet
https://github.com/pharmaverse/admiral/blob/main/inst/cheatsheet/admiral_cheatsheet.pptx

Definition of Done

  • Update derive_var_trtemfl() arguments
  • Cross check that no deprecated functions or arguments are in cheatsheet
  • Review 1.1.0 news.md to see if any other amendments are needed
  • Re-colour bracket in derive_vars_crit_flag()
  • Add brackets and remove space in derive_var_base/chg()
  • Update bracket colour for convert_blanks_to_na()
  • Add derive_vars_cat() and derive_vars_crit_flag() to General Variable-Adding functions
  • Add transform_range() to Computation functions for Vectors
  • Update derive_vars_atc() to add ... or id_vars argument

@pharmaverse/admiral @pharmaverse/admiral_comm Great way to get more familiar with the package. I would imagine this is a 1-2 hour task. This does not impact 1.1.0 release timelines and so is not needed immediately...but nice to have in the next week.

@bms63 bms63 added the documentation Improvements or additions to documentation label Jun 6, 2024
@bundfussr bundfussr self-assigned this Jul 12, 2024
@bundfussr
Copy link
Collaborator

I had a look. I think we don't need to update derive_vars_trtemfl() because on the cheatsheet only the main arguments are mentioned. Thus I wouldn't add group_var.

I would update only derive_vars_atc() by adding the new argument id_var or just ... depending on what fits.

However, I noticed that the webpage links to the development version of the cheatsheet. I.e., the users already see the derive_vars_crit_flag() function although it is not yet available. I wonder if should change the links such that it refers to the released version. We could submit our cheatsheet to rstudio/cheatsheets and refer in our documentation to the cheatsheet in rstudio/cheatsheets.
Another option would be to copy the cheatsheet from the inst folder to the docs folder when we build the documentation and refer to the docs folder in the documentation. However, the first options seems the more common one to me.

@bms63 , @manciniedoardo , what do you think?

@bundfussr bundfussr moved this from Backlog to In Progress in admiral (sdtm/adam, dev, ci, template, core) Jul 12, 2024
@bms63
Copy link
Collaborator Author

bms63 commented Jul 12, 2024

I like submitting to rstudio/cheatsheets. Gets us more exposure.

@manciniedoardo
Copy link
Collaborator

I like the idea too!

@bundfussr
Copy link
Collaborator

OK, I'll submit the cheatsheet for 1.1.1.

@bundfussr
Copy link
Collaborator

@manciniedoardo , for the submission to rstudio/cheatsheets I need to add an author name to the cheatsheet. As you did most of the work, I would suggest to add your name.

Do you agree?

@manciniedoardo
Copy link
Collaborator

@bundfussr yes sure, thanks!

@bundfussr
Copy link
Collaborator

I've submitted the cheatsheet: rstudio/cheatsheets#555

@bundfussr bundfussr moved this from In Progress to In Review in admiral (sdtm/adam, dev, ci, template, core) Jul 15, 2024
@bms63
Copy link
Collaborator Author

bms63 commented Jul 15, 2024

Thanks @bundfussr !!

@bundfussr
Copy link
Collaborator

I've created the branch 2458_update_cheatsheet to store the admiral 1.1.1 cheatsheet. However, this branch shouldn't be merged to main as it would conflict with the cheatsheet updates for #2468. I'll add the admiral 1.1.1 cheatsheet updates to the 2468_derive_vars_crit_flag branch.

Copy link

This issue is stale because it has been open for 90 days with no activity.

@github-actions github-actions bot added the stale label Oct 14, 2024
@manciniedoardo manciniedoardo changed the title Documentation: Bring cheatsheet into alignment with 1.1.0 changes Documentation: Bring cheatsheet into alignment with 1.1.0 and 1.2.0 changes Dec 10, 2024
@manciniedoardo manciniedoardo self-assigned this Dec 10, 2024
@manciniedoardo
Copy link
Collaborator

As discussed with @bundfuss, the PR to add the cheatsheet to Rstudio/cheatsheets is still not merged. So we can use this opportunity to make changes to align with 1.2 and then perhaps update that PR as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Development

Successfully merging a pull request may close this issue.

3 participants