Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General Issue: derive_vars_aage() argument should be update from age to age_unit #2025

Closed
3 tasks
bms63 opened this issue Jul 20, 2023 · 0 comments · Fixed by #2009
Closed
3 tasks

General Issue: derive_vars_aage() argument should be update from age to age_unit #2025

bms63 opened this issue Jul 20, 2023 · 0 comments · Fixed by #2009
Assignees
@manciniedoardo
Labels
function re-work issues identified by function re-work gang - usually argument alignment, user friendliness general issue

Comments

@bms63
Copy link
Collaborator

bms63 commented Jul 20, 2023

Background Information

AS part of our efforts to get to a 1.0 version of admiral, we are looking over all functions for consistency and user-friendliness.

To be consistent with the age-realted function, the age argument for derive_vars_aage() should be update from age to age_unit

image

Definition of Done

  • Function argument and description updated
  • Deprecation process followed for arguments
  • Tests, vignettes and templates updated as needed
@bms63 bms63 added the function re-work issues identified by function re-work gang - usually argument alignment, user friendliness label Jul 24, 2023
@bms63 bms63 linked a pull request Jul 30, 2023 that will close this issue
Closes #2001 Added processing for missing age_units in compute_age_years #2009
Merged
13 tasks
@bms63 bms63 closed this as completed Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manciniedoardo manciniedoardo

Labels
function re-work issues identified by function re-work gang - usually argument alignment, user friendliness general issue
Projects
admiral (sdtm/adam, dev, ci, template, core)
Status: Archive
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #2001 Added processing for missing age_units in compute_age_years pharmaverse/admiral
2 participants
@bms63 @manciniedoardo