Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Rejected packages #3

Open
jmanitz opened this issue Apr 26, 2022 · 5 comments
Open

General: Rejected packages #3

jmanitz opened this issue Apr 26, 2022 · 5 comments

Comments

@jmanitz
Copy link
Collaborator

jmanitz commented Apr 26, 2022

One topic area I would love if any groups were willing to share, is what specific packages have been rejected while going through the quality process. It would be interesting to see if packages are being rejected by some orgs but not others, and what parts of their risk criteria cause that differentiation

@jmanitz
Copy link
Collaborator Author

jmanitz commented Apr 26, 2022

Follow-up to my above question - can people share any examples where this process caught errors during the assessment process

@bizzinho
Copy link
Contributor

For NVS, there have been several high-risk packages that were requested by users who, when confronted with the task of writing PQ tests, opted to withdraw their request. This happens for a few packages in almost every release.

Similarly, out internal tool used for automating large parts of this process, usually undergoes several changes after each release, based on lessons learned.

@maksymiuks
Copy link

maksymiuks commented May 5, 2022

For Roche, we had to reject a few CRAN packages that were requested by our users to be used in a validated environment. Those were multgee, ggpp, and blscrapeR. During the evaluation of those packages, we assessed that they don't meet some of the requirements out in front of the R packages in Roche. In those cases, these requirements were: tests coverage below 80% and some of the exported functions not covered by any of the unit tests. Additionally, packages are not well adapted, as all three of them have a total CRAN downloads number below 100000, and they are not associated with any major software development entity. Based on that we couldn't validate those as we don't have enough proofs that the code works as expected and is actively maintained.

EDIT: fixed typo

@bizzinho
Copy link
Contributor

bizzinho commented May 9, 2022

hey @maksymiuks , what do you mean by

downloads number below 100%

? Thanks!

@maksymiuks
Copy link

@bizzinho Brain lag, I think, I meant 100000 downloads :) Thank you for pointing this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants