Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: ValidationInterface - add : parameters not correct #14946

Closed
niden opened this issue Apr 10, 2020 · 3 comments
Closed

[BUG]: ValidationInterface - add : parameters not correct #14946

niden opened this issue Apr 10, 2020 · 3 comments
Assignees
@niden @Izopi4a
Labels
5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility bug A bug report status: low Low

Comments

@niden
Copy link
Member

niden commented Apr 10, 2020

Same on Visual Studio Code.
Also, in ValidationInterface::add first argument's type is string, whereas it can be string or an array.

Originally posted by @wmamrak in #14818 (comment)
@niden niden added breaks bc Functionality that breaks Backwards Compatibility bug A bug report status: low Low labels Apr 10, 2020
@ruudboon ruudboon changed the title ValidationInterface - add : parameters not correct [BUG] ValidationInterface - add : parameters not correct Apr 30, 2020
@ruudboon ruudboon changed the title [BUG] ValidationInterface - add : parameters not correct [BUG]: ValidationInterface - add : parameters not correct Apr 30, 2020
@zsilbi zsilbi added the 6.0 The issues we want to solve in the 6.0 release label Sep 10, 2020
@zsilbi zsilbi added the transfer label Oct 6, 2020
@Jeckerson Jeckerson mentioned this issue Nov 21, 2020
Closed
5 tasks
@Jeckerson
Copy link
Member

@zsilbi Are we really need to push that fix to the 6.0. As it seems to be bug, or at least make sense to fix that in v5?

@zsilbi
Copy link
Member

zsilbi commented Dec 9, 2020

@zsilbi Are we really need to push that fix to the 6.0. As it seems to be bug, or at least make sense to fix that in v5?

I labeled every issue with v6 which requires interface changes by default. Please override that wherever you think.

@Jeckerson Jeckerson added 5.0 The issues we want to solve in the 5.0 release and removed 6.0 The issues we want to solve in the 6.0 release labels Jan 5, 2021
@Izopi4a Izopi4a mentioned this issue Mar 29, 2021
Merged
5 tasks
@niden
Copy link
Member Author

niden commented Mar 31, 2021

Resolved in #15352

@niden niden closed this as completed Mar 31, 2021
@niden niden moved this to Released in Phalcon v5 Aug 25, 2022
@niden niden added this to Phalcon v5 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niden niden

@Izopi4a Izopi4a

Labels
5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility bug A bug report status: low Low
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@niden @Jeckerson @zsilbi @Izopi4a