iCloud photo.filename value not always unique

[cjenow]

Hi @pablogzalez ,

I found that not all of my iCloud photos were backing up. When I investigated why, I realized that within my Photos album, there are some filenames that actually have more than one unique photo. The current logic assumes that the photo.filename refers to a unique photo, but this is not true. To make the filename on disk truly unique, I've locally updated a version of the code that starts like this to make the filesystem filename the (likely unique) id, followed by the filename. I noticed that some iCloud photo IDs have / characters, and I replaced those with underscores to enable them to be valid local filenames.

for index, photo in enumerate(photos_to_backup, start=1):
        print(f"⏳ Realizando backup {index}/{len(photos_to_backup)}...", end='\r')
        photo_id_with_filename = photo.id.replace("/","_") + "_" + photo.filename

I am testing this now, if it's agreed that this is a good approach, and if finally backs up my whole library (judging by size in GB on disk compared to size of Photos in iCloud), then I will clean up my code modifications & make a pull request.