Fix: ar variable in Makefile to inherit upstream ar command #217
Conversation
|
@gregnr Thanks for the contribution! I think that looks good, with one minor question inline. |
|
@lfittl thanks for the quick review! I've pushed an update based on your suggestion. PS. are you open to applying this change retroactively to v13 and v14 branches for backwards support? If so I can create 2 more PR's for those. |
We generally don't back patch, unless there is a good reason to do so. But not against it per se. Do you have a use case that requires using older parser versions? |
|
Thanks for merging!
Yes - I was planning to support v13 and v14 WASM builds as well (when paired with older Postgres versions), for which I would reference the respective version tags on this repo (v13, v14). But they will need the same |
Ack, makes sense. I think we can support that, if you want to make a PR for them :) |
I finally got around to doing this. Here are the PR's for v13 and v14:
Thanks @lfittl! |
@gregnr Great, thanks - merged both! Did you need tagged patch releases for your use case, or is having them in the respective branches sufficient? |
|
Thanks @lfittl! A tagged release for v13 and v14 would be amazing if possible. Otherwise I can always reference a commit instead. |
Fantastic library!
I'm working on compiling this library to WASM using Emscripten (specifically for libpg-query-node). Emscripten has a command
emmakethat simply wrapsmakewithCC,CXX,AR, etc set to the Emscripten drop-in replacements (emcc,em++,emar).Surprisingly running
emmake makeon this repository'sMakefileJustWorked™ with the exception of a one-line change to theMakefilewhich is what this PR proposes.We just need to replace the hardcoded
ARvariable:with a reference to the upstream inherited
ARvariable:so that Emscripten's
emarreplacement is used.Let me know if you have any questions or need any more clarification.