Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lost-column gutter requiring cycle when using short-hand #181

Closed
1 task done
peterramsing opened this issue Oct 7, 2015 · 11 comments
Closed
1 task done

lost-column gutter requiring cycle when using short-hand #181

peterramsing opened this issue Oct 7, 2015 · 11 comments

Comments

@peterramsing
Copy link
Owner

@corysimmons When using lost-column shorthand I spaced a custom gutter and in the shorthand it requires the cycle to be spec'd. I'd like to be able to set the gutter without having to also spec a cycle...but that could just be me.

  1. If this is on purpose I'll update the README for this gotcha (unless I just totally missed it...)
  2. If this should be more adaptive then I suppose I can work on updating the lib/lost-column.js . see Allow for parameter order to not matter #213

  • Update the README to reflect this
@corysimmons
Copy link
Contributor

The cycle needs to be specified if you're using the shorthand. It's very similar to other CSS shorthand where certain things need to appear in a certain order. Am I understand your question correctly?

@peterramsing
Copy link
Owner Author

Yes, I think you are. We just had a discussion about this in our office. If you look at a rule such as border you can leave out values and it falls back to default. That's what I'm referring to here. If I leave the cycle value out it would be nice if it stayed default.

@corysimmons
Copy link
Contributor

I see what you're saying. I'd love to have that feature but couldn't figure out how to do it when I built Lost.

@peterramsing
Copy link
Owner Author

Want to label this as a bug and I'll see what I can do?

@corysimmons
Copy link
Contributor

It's not really a bug imo but I can label it an enhancement.

@peterramsing
Copy link
Owner Author

Sweeeeet! I'll see if I can find some time in the coming evenings to figure out a plan of attack...

@sidonaldson
Copy link

Surely a gutter value always has to have a unit, whereas a cycle is an integer and flex is a string. Could it be improved so that order isn't required?

@corysimmons
Copy link
Contributor

It's possible with several conditionals, but I'm not sure how much of a benefit it'd be.

@peterramsing
Copy link
Owner Author

Being that other css properties act as @sidonaldson is saying, it might be worth while. Maybe over the holiday I'll have some time to address this issue and see what it would take to make it order agnostic.

border-bottom: 1px dotted; == border-bottom: dotted 1px;

I'd say it's worth attempting.

@corysimmons
Copy link
Contributor

I don't think all CSS properties are order agnostic, but I don't suppose it could hurt.

@peterramsing
Copy link
Owner Author

Since this is acting as expected (in shorthand all params must be preset), I'm going to update the readme instead, but this discussions continued in #213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment