Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding Python 3 support #3

Open
cgoldberg opened this issue Aug 28, 2016 · 1 comment
Open

adding Python 3 support #3

cgoldberg opened this issue Aug 28, 2016 · 1 comment

Comments

@cgoldberg
Copy link

Hi @peterlevi ,
Do you have plans for porting variety-slideshow to Python 3? If not, would you be willing to accept a PR if I contributed it?

The only dependency used in variety is the gi package... and python3-gi has been in the Ubuntu archive since 12.04. Besides gi.repository, the variety codebase uses only standard library modules... so that would be a straight forward effort to support Python 3.

There are basically 2 ways to approach Python 3 compatibility:

  1. convert entire source to Python 3 syntax and drop Python 2 support
  2. modify variety-slideshow so there is a single codebase that supports both Python2 and Python3 (with conditional imports and such)

Which way would you like to see variety go?

Thanks!

-Corey

@peterlevi
Copy link
Owner

Hi @cgoldberg,

Sorry for slow response, quite busy with work recently, not much time for the personal projects. But I'm happy to hear there's contributors' interest!

I hadn't planned on porting to Python 3, but, yes, I would accept a PR that makes it support both Python 2 and 3. Dropping Python 2 is a no-go for now, because variety-slideshow is (to some extent) part of Variety (https://launchpad.net/variety) which is Python 2 only, no plans to port that one for now, and I'd prefer Variety + Slideshow combined to require one Python version only on the machine, not both.

Thanks,
Peter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants