Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appendixes.mlx file does not run in 24b due to vision.LocalMaximaFinder deprecation #7

Open
remo-pillat opened this issue Dec 2, 2024 · 0 comments
Assignees

Comments

@remo-pillat
Copy link
Collaborator

Describe the bug
I recently ran all of our RVC3 book tests (running the MLX chapter files) with 24b.
There was an error complaining about vision.LocalMaximaFinder being removed in appendices.mlx. I assume that file has been deprecated. Is there a reason why you don't have an alias for this function in CVT (you don't have to document it, but removing it entirely will probably hit some customers)?

I suggest the following:
(1) you update the MLX to use the best alternative function. Make sure that the alternative function also works with MATLAB 23a (that's the version we promise to work in the book).

(2) you leave a comment in the MLX file that you replaced the usage of vision.LocalMaximaFinder in 24b

Error snippet:

2024-12-02T04:02:33.8775415Z ================================================================================
2024-12-02T04:02:33.8776821Z Error occurred in tAppendices/runMLXFile and it did not run to completion.
2024-12-02T04:02:33.8778118Z ---------
2024-12-02T04:02:33.8778763Z Error ID:
2024-12-02T04:02:33.8779243Z ---------
2024-12-02T04:02:33.8779794Z 'vision:obsolete:removeFunctionalityReplacedWithTwo'
2024-12-02T04:02:33.8780380Z --------------
2024-12-02T04:02:33.8780981Z Error Details:
2024-12-02T04:02:33.8781414Z --------------
2024-12-02T04:02:33.8781825Z Error using vision.LocalMaximaFinder
2024-12-02T04:02:33.8782676Z vision.LocalMaximaFinder has been removed. Use the houghpeaks and
2024-12-02T04:02:33.8783172Z imregionalmax
2024-12-02T04:02:33.8783633Z functions with equivalent functionality instead.
2024-12-02T04:02:33.8783999Z
2024-12-02T04:02:33.8784285Z Error in appendices (line 118)
2024-12-02T04:02:33.8784820Z LMaxFinder = vision.LocalMaximaFinder(MaximumNumLocalMaxima=3, ...
2024-12-02T04:02:33.8785263Z
2024-12-02T04:02:33.8785553Z Error in run (line 112)
2024-12-02T04:02:33.8785961Z evalin('caller', strcat(scriptStem, ';'));
2024-12-02T04:02:33.8786302Z
2024-12-02T04:02:33.8786599Z Error in RunMLX/runFile (line 57)
2024-12-02T04:02:33.8787005Z run(testCase.MLXFile);
2024-12-02T04:02:33.8787289Z
2024-12-02T04:02:33.8787913Z Error in RunMLX>@(varargin)testCase.runFile(varargin{:}) (line 48)
2024-12-02T04:02:33.8788469Z testCase.verifyWarningFree(@testCase.runFile, ...
2024-12-02T04:02:33.8788815Z
2024-12-02T04:02:33.8789061Z Error in
2024-12-02T04:02:33.8789533Z matlab.unittest.internal.constraints.FunctionHandleConstraint/invoke (line
2024-12-02T04:02:33.8789980Z 35)
2024-12-02T04:02:33.8790262Z [varargout{1:nargout}] = fcn();
2024-12-02T04:02:33.8790645Z
2024-12-02T04:02:33.8790873Z Error in
2024-12-02T04:02:33.8791301Z matlab.unittest.internal.constraints.WarningQualificationConstraint/invoke
2024-12-02T04:02:33.8791831Z (line 43)
2024-12-02T04:02:33.8792277Z constraint.invoke@matlab.unittest.internal.constraints.FunctionHandleConstraint(fcn);
2024-12-02T04:02:33.8792793Z
2024-12-02T04:02:33.8793235Z Error in matlab.unittest.constraints.IssuesNoWarnings/issuesNoWarnings (line
2024-12-02T04:02:33.8793684Z 141)
2024-12-02T04:02:33.8793943Z constraint.invoke(actual);
2024-12-02T04:02:33.8794310Z
2024-12-02T04:02:33.8794677Z Error in matlab.unittest.constraints.IssuesNoWarnings/satisfiedBy (line 84)
2024-12-02T04:02:33.8795165Z constraint.issuesNoWarnings(actual);
2024-12-02T04:02:33.8795558Z
2024-12-02T04:02:33.8795798Z Error in
2024-12-02T04:02:33.8796208Z matlab.unittest.internal.constraints.CasualDiagnosticDecorator/satisfiedBy
2024-12-02T04:02:33.8796770Z (line 42)
2024-12-02T04:02:33.8797056Z bool = decorator.Constraint.satisfiedBy(actual);
2024-12-02T04:02:33.8797410Z
2024-12-02T04:02:33.8797708Z Error in
2024-12-02T04:02:33.8798093Z matlab.unittest.internal.qualifications.QualificationDelegate/qualifyThat
2024-12-02T04:02:33.8798867Z (line 82)
2024-12-02T04:02:33.8799226Z result = constraint.satisfiedBy(actual);
2024-12-02T04:02:33.8799548Z
2024-12-02T04:02:33.8799793Z Error in
2024-12-02T04:02:33.8800275Z matlab.unittest.internal.qualifications.QualificationDelegate/qualifyWarningFree
2024-12-02T04:02:33.8800759Z (line 224)
2024-12-02T04:02:33.8801115Z delegate.qualifyThat(qualifiable, notificationData, actual,
2024-12-02T04:02:33.8801787Z issuesNoWarningsWithOutputs, varargin{:});
2024-12-02T04:02:33.8802168Z
2024-12-02T04:02:33.8802573Z Error in matlab.unittest.qualifications.Verifiable/verifyWarningFree (line
2024-12-02T04:02:33.8803103Z 833)
2024-12-02T04:02:33.8803338Z [varargout{1:nargout}] =
2024-12-02T04:02:33.8803753Z qualifyWarningFree(verifiable.VerificationDelegate, ...
2024-12-02T04:02:33.8804181Z
2024-12-02T04:02:33.8804431Z Error in RunMLX/runMLXFile (line 48)
2024-12-02T04:02:33.8804815Z testCase.verifyWarningFree(@testCase.runFile, ...
2024-12-02T04:02:33.8805270Z ================================================================================

See the full error log here: https://tinyurl.com/bddb8r82.

To Reproduce
Run appendices.mlx in MATLAB 24b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants