New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Insight] PHP methods should not contain too much logic #9

Open

peter-gribanov opened this issue Apr 4, 2016 · 0 comments

Owner

peter-gribanov commented Apr 4, 2016

8% of all methods have more than 50 lines. This violation is raised when more than 5% methods are too long.

137 lines for SphinxClient::buildExcerpts() in src/SphinxClient.php, line 1501
134 lines for SphinxClient::parseSearchResponse() in src/SphinxClient.php, line 1324
99 lines for SphinxClient::addQuery() in src/SphinxClient.php, line 1157
60 lines for SphinxClient::updateAttributes() in src/SphinxClient.php, line 1770

Posted from SensioLabsInsight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment