Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot find matching comments when the thread in the PR exceeds 30 comments #24

Closed
p-costa opened this issue Oct 1, 2020 · 5 comments · Fixed by #27
Closed

cannot find matching comments when the thread in the PR exceeds 30 comments #24

p-costa opened this issue Oct 1, 2020 · 5 comments · Fixed by #27

Comments

@p-costa
Copy link

p-costa commented Oct 1, 2020

Hi,

I am testing this workflow and it works like a charm, except for this issue that I'm facing:

If the comment that matches the keyword that I seek is the 31st comment or more in the thread, find-comment does not detect it. Have you experienced this issue?

Thank you,
Pedro

@p-costa
Copy link
Author

p-costa commented Oct 2, 2020

Perhaps the discussion here is relevant, and this solution may fix the issue.

@peter-evans
Copy link
Owner

Hi @p-costa

Yes, this is because of the default per_page on API requests. The Octokit instance uses the octokit-paginate-rest plugin and I though it was in use already, but I might not be using it at all. I'll investigate.

https://github.com/actions/toolkit/blob/main/packages/github/src/utils.ts#L22

@p-costa
Copy link
Author

p-costa commented Oct 2, 2020

Thank you, @peter-evans ! Looking forward to hearing from you.

@peter-evans
Copy link
Owner

This should be fixed in the latest release. Thanks for reporting!

@p-costa
Copy link
Author

p-costa commented Oct 5, 2020

Perfect! I tested and it worked fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants