Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to another module than File::Slurp #100

Open
petdance opened this issue Oct 25, 2018 · 4 comments
Open

Switch to another module than File::Slurp #100

petdance opened this issue Oct 25, 2018 · 4 comments

Comments

@petdance
Copy link
Owner

File::Slurp will break under Perl 5.30. Switch to something else, if not just writing my own read_file.

dz-at-tc added a commit to dz-at-tc/bobby-tables that referenced this issue Oct 4, 2021
dz-at-tc added a commit to dz-at-tc/bobby-tables that referenced this issue Oct 4, 2021
@dz-at-tc
Copy link
Contributor

dz-at-tc commented Oct 4, 2021

Hi @petdance , I wasn't sure whether eliminating a dependency entirely or clarity via retaining a dependency was the priority here, so I did it both ways. Or perhaps there is a door number three you had in mind? :)

@dz-at-tc
Copy link
Contributor

dz-at-tc commented Oct 8, 2021

Hey @petdance , so none of the above, eh?

We could squirrel away the do/local/<> idiom ugliness like so...

sub read_file {
    return do {local(@ARGV, $/) = shift; <>};
}

... if that makes any difference?

@petdance
Copy link
Owner Author

petdance commented Oct 8, 2021

Hey @petdance , so none of the above, eh?

No, I just haven't had time to work on it yet. Other things have taken precedence. I appreciate the PR.

@dz-at-tc
Copy link
Contributor

dz-at-tc commented Oct 8, 2021

Ahhh, but of course (in my best Grey Poupon :)

Apologies for the line noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants