DatasetMissing error when using a function inside with

[HassanZahirnia]

Hey,

I'm trying to run this code:

it('will pass if decoded hashid exists', function (string $value, bool $expectedResult) {
    employee();
    $result = (new ExistsWithDecodedHashid('users', 'id'))->passes('id', $value);
    expect($result)->toBe($expectedResult);
})->with([
    [\Hashids::encode(1), true],
    ['1', false],
]);

But I get this error:

 Pest\Exceptions\DatasetMissing 

  A test with the description 'it will pass if decoded hashid exists' has 2 argument(s) ([string $value, bool $expectedResult]) and no dataset(s) provided

It appears the \Hashids::encode(1) (from vinkla/hashids package) doesn't get resolved at the right time or something?

I tried this and it works when testing individually but will fail when running all tests together:

->with([
    [fn (): string => \Hashids::encode(1), true],
    ['1', false],
]);

Although with this approach the test title will become:

it will pass if decoded hashid exists with (Closure Object (...), true)

Which isn't ideal.

[owenvoke]

It looks like you're calling \Hashids with a static method, so I'm assuming you've aliased this class as a facade? It's very likely that this is throwing an error or exception, which means the dataset can't be resolved.

In your case, assuming it's a facade, the container hasn't been bound at this point, so you could either resolve it as you've already done (but provide a name for the dataset entry), or use Bound Datasets.

I'm wondering if we could maybe catch exceptions in dataset resolution and provide a cleaner / more helpful error message, as I too experienced this the other day.

[HassanZahirnia]

Thanks for your reply.
May I ask what do you mean by "provide a name for the dataset entry" ?

I encountered another issue with datasets today, although it may not directly be related to this topic, but when I try this code:

it('will not allow guest users to manage holiday cards', function (Closure $request) {
    $holidayCard = HolidayCard::factory()->withPhoto()->create();

    $response = $request($holidayCard);

    expect($response)->assertRedirect(route('login'));
})->with('requests');

dataset('requests', [
    fn (HolidayCard $holidayCard): TestResponse => get(action([HolidayCardController::class, 'index'])),
    fn (HolidayCard $holidayCard): TestResponse => get(action([HolidayCardController::class, 'create'])),
    fn (HolidayCard $holidayCard): TestResponse => post(action([HolidayCardController::class, 'store'])),
    fn (HolidayCard $holidayCard): TestResponse => get(action([HolidayCardController::class, 'edit'], $holidayCard)),
    fn (HolidayCard $holidayCard): TestResponse => put(action([HolidayCardController::class, 'update'], $holidayCard)),
    fn (HolidayCard $holidayCard): TestResponse => delete(action([HolidayCardController::class, 'destroy'], $holidayCard)),
]);

I keep getting this error:

  • Tests\Feature\Policies\HolidayCardPolicyTest > it will not allow guest users to manage holiday cards with (Closure Object (...)) #6
   ArgumentCountError 

  Too few arguments to function P\Tests\Feature\Policies\HolidayCardPolicyTest::{closure}(), 0 passed and exactly 1 expected

I searched everywhere and couldn't find an answer. Do you have any idea what I'm doing wrong here ?

[owenvoke]

Try prefixing all of the datasets with an fn () =>, I think it's basically thinking that the short closures are bound datasets, and so it's trying to pass the value of the closure rather than the actual closure to the test (i.e. trying to resolve the result of get() outside of container binding).

By the description, I just meant that to make your test output a bit clearer (rather than having with (Closure(...)), you can name them with something like:

->with([
    'Hashids::encode(1), true' => [fn (): string => \Hashids::encode(1), true],
    '1, false' => ['1', false],
]);

Although, I think that still won't work for you (just re-read your issue).

Perhaps for the first test, try:

it('will pass if decoded hashid exists', function (string $value, bool $expectedResult) {
    employee();
    $result = (new ExistsWithDecodedHashid('users', 'id'))->passes('id', $value);
    expect($result)->toBe($expectedResult);
})->with([
    fn () => [\Hashids::encode(1), true],
    fn () => ['1', false],
]);

And for the second, try:

it('will not allow guest users to manage holiday cards', function (Closure $request) {
    $holidayCard = HolidayCard::factory()->withPhoto()->create();

    $response = $request($holidayCard);

    expect($response)->assertRedirect(route('login'));
})->with('requests');

dataset('requests', [
    fn () => fn (HolidayCard $holidayCard): TestResponse => get(action([HolidayCardController::class, 'index'])),
    fn () => fn (HolidayCard $holidayCard): TestResponse => get(action([HolidayCardController::class, 'create'])),
    fn () => fn (HolidayCard $holidayCard): TestResponse => post(action([HolidayCardController::class, 'store'])),
    fn () => fn (HolidayCard $holidayCard): TestResponse => get(action([HolidayCardController::class, 'edit'], $holidayCard)),
    fn () => fn (HolidayCard $holidayCard): TestResponse => put(action([HolidayCardController::class, 'update'], $holidayCard)),
    fn () => fn (HolidayCard $holidayCard): TestResponse => delete(action([HolidayCardController::class, 'destroy'], $holidayCard)),
]);

[HassanZahirnia]

Thank you very much !
Although the first one requires argument changes since it will fail as returned result is an array.

As for the second one, your solution totally works. Although I'm not sure if this is an issue with Pest or it's intended by design.
I was watching the Spatie's laravel testing video course and they used this method of shared datasets to clean up the code, although in the video his example works and their tests passes, but now I can't use same approach. I'm assuming something has changed in Pest core since that video was published last year and that's why it doesn't work.