Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement v4 API functions for Deposit #52

Open
peshay opened this issue Apr 10, 2021 · 2 comments
Open

Implement v4 API functions for Deposit #52

peshay opened this issue Apr 10, 2021 · 2 comments
Labels
API Functionality that is directly related to bitcoin.de offered API help wanted

Comments

@peshay
Copy link
Owner

peshay commented Apr 10, 2021

No description provided.

@peshay peshay added help wanted API Functionality that is directly related to bitcoin.de offered API labels Apr 11, 2021
@CosmicDuck
Copy link

CosmicDuck commented Mar 17, 2022

Hi, I added a new short function in the definition for showDeposits which is working well for the moment. I have no playing experience with github so here is my code which I inserted before showAccountInfo() procedure:

`
showDeposits()

def showDeposits(self, currency, **args):
    """Query on Deposits."""
    params = args
    avail_params = [ 'deposit_id', 'page' ]
    uri = f'{self.apibase}{currency}/deposits'
    p = ParameterBuilder(avail_params, params, uri)
    return self.APIConnect('GET', p)

`

@peshay
Copy link
Owner Author

peshay commented Mar 17, 2022

Can you create a PR for it, with a unit test and documentation about that function in the README?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Functionality that is directly related to bitcoin.de offered API help wanted
Projects
None yet
Development

No branches or pull requests

2 participants