Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some issue about leap year calculation #1

Open
Ali-Javanmardi opened this issue Dec 26, 2020 · 0 comments
Open

Some issue about leap year calculation #1

Ali-Javanmardi opened this issue Dec 26, 2020 · 0 comments

Comments

@Ali-Javanmardi
Copy link

Dear Jalali developers,

Today I saw your project about Jalali calendar.
First of all it was interesting to me that I saw you started a new Jalali calendar in GO and I hope you have motivation to extend your nice work for other languages as well.
I have same idea in mind and I started a project in this subject a few month ego.

So I started to investigate why we have such problems converting Jalali calendar to Gregorian calendar.
Here you can view what I learned : https://github.com/Ali-Javanmardi/Persian-Jalali-calendar-converter

As you may find there I made a comparison table for different leap year calculation methods and unfortunately I found that method suggested by Musa Akrami is not error proof.

At the moment I focused to calculate more accurate leap year by calculating astronomical algorithms introduced by Jean Meeus in his book Astronomical Algorithms (1998), 2nd ed, ISBN 0-943396-61-1

Honestly my try is an overkill and a simple method with less code has more value in real life, but as a matter of accuracy I suggest you have a look on Mohammad Reza Sayyad article here: http://mirasmaktoob.ir/fa/system/files/nashriat/ME3-Sayad-Sal.pdf

By my comparison table his job looks better, but unfortunately his calculation is more difficult to implement in less code.

Hope you find it useful in your way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant