Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_results.py reference to file path #164

Open
shuttle1987 opened this issue Jun 1, 2018 · 1 comment
Open

test_results.py reference to file path #164

shuttle1987 opened this issue Jun 1, 2018 · 1 comment

Comments

@shuttle1987
Copy link
Member

shuttle1987 commented Jun 1, 2018

@pytest.fixture(scope="module",
params=["test", "valid"])
def prepared_data(request):
data_path = Path("testing/data/bkw")
exp_path = Path("testing/exp/19/")

This appears to reference a file path that may not exist since testing/ is explicitly in .gitignore. These tests could fail machine because of the lack of this file or worse be referencing some other unrelated experiment.

I would like to instead make reference to a test fixture here. Additionally I notice that there's a Corpus constructed from a pickle file, this is something we could potentially add in as a file into version control but I'm a bit concerned about adding in pickle files like that in general.

@shuttle1987
Copy link
Member Author

Looking at the test_results.py test file has given me more insight into what's happening. I think we can get good test coverage of results.py with a combination of mocks by extracting the results from a test run, I don't think we need a full Corpus object here because we aren't really using it aside from extracting utterance and label info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant