You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This appears to reference a file path that may not exist since testing/ is explicitly in .gitignore. These tests could fail machine because of the lack of this file or worse be referencing some other unrelated experiment.
I would like to instead make reference to a test fixture here. Additionally I notice that there's a Corpus constructed from a pickle file, this is something we could potentially add in as a file into version control but I'm a bit concerned about adding in pickle files like that in general.
The text was updated successfully, but these errors were encountered:
Looking at the test_results.py test file has given me more insight into what's happening. I think we can get good test coverage of results.py with a combination of mocks by extracting the results from a test run, I don't think we need a full Corpus object here because we aren't really using it aside from extracting utterance and label info.
persephone/persephone/tests/test_results.py
Lines 15 to 20 in 53f9575
This appears to reference a file path that may not exist since
testing/
is explicitly in.gitignore
. These tests could fail machine because of the lack of this file or worse be referencing some other unrelated experiment.I would like to instead make reference to a test fixture here. Additionally I notice that there's a Corpus constructed from a pickle file, this is something we could potentially add in as a file into version control but I'm a bit concerned about adding in pickle files like that in general.
The text was updated successfully, but these errors were encountered: