Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graceful restart. #228

Open
rkeene opened this issue Sep 18, 2019 · 1 comment
Open

Graceful restart. #228

rkeene opened this issue Sep 18, 2019 · 1 comment
Assignees
@hasyimibhar
Labels
enhancement New feature or request

Comments

@rkeene
Copy link
Contributor

rkeene commented Sep 18, 2019

Recently we added a restart mechanism (#204). This restart is not very graceful.

In particular, transactions which we have adding locally but not gossiped out may be lost.

If possible, have the restart mechanism shutdown the listener RPC listener and wait a bit before restarting to give this a greater chance of gossiping out transactions.
@iwasaki-kenta
Copy link
Contributor

Was this implemented in the recent ledger cleanup @hasyimibhar?

@iwasaki-kenta iwasaki-kenta added the enhancement New feature or request label Oct 10, 2019
@iwasaki-kenta iwasaki-kenta changed the title Graceful Restart Graceful restart. Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hasyimibhar hasyimibhar

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hasyimibhar @rkeene @iwasaki-kenta