getline method is inoperative and maybe outdated #183

Openstreetmapler · 2023-04-20T09:47:57Z

In my installation of Catalyst, I had to replace this line of code

Line 4091 in ff923f7

$slurped = $fh->getline;

with a filehandle read operation (print and comments are not required)

            #! WORKAROUND: using the old and reliable filehandle method
            #- because $fh->getline doesn't return the JSON!
            open(FH, $fh);
            $slurped = <FH>;
            print("*DEBUG* slurped is $slurped\n");
            close(FH);
            #! END OF WORKAROUND

because the getline makes the $slurped variable not have any content, which causes a JSON malformed error when attempting to access the HTTP request body via $c->req->body_data:

[2023/04/20 10:31:12] [catalyst] [ERROR] Error Parsing POST 'undef', Error: malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 at /home/nasaruk/perl5/lib/perl5/Catalyst.pm line 4092, <$fh> chunk 1.
[2023/04/20 10:31:12] [catalyst] [DEBUG] Response Code: 500; Content-Type: unknown; Content-Length: unknown

Maybe that getline method is heavily outdated and no-one noticed that it ceased to work.

The text was updated successfully, but these errors were encountered:

jjn1056 · 2023-04-20T13:24:55Z

I don't think get line is outdated; can I get a test case that shows this issue?

Openstreetmapler · 2023-04-21T10:58:26Z

What should test case look like?

jjn1056 · 2023-04-21T12:39:38Z

Ideally it should be a failing test that shows the problem. We need to know how you are getting this error. There's a simple test case that has some JSON in it at https://github.com/perl-catalyst/catalyst-runtime/blob/master/t/content_negotiation.t that you might want to crib.

Openstreetmapler · 2023-04-24T06:30:09Z

~~How do I run the test script? I don’t have the TestContentNegotiation module and it’s not a CPAN module.~~

EDIT: Oops, rookie mistake! I tried to install TestContentNegation from CPAN when the module is actually called TestContentNegotiation!

EDIT2: However, neither of these modules are found in CPAN! Can you please tell me where that module is to be found?

haarg · 2023-04-24T16:21:50Z

That modules is included in the t/lib directory.

perl-catalyst-sync · 2023-04-24T16:49:33Z

generally run test cases from the commandline, in the project root directory like prove -lvr t/$NAMEOFTEST

…

-jn

On Mon, Apr 24, 2023 at 11:22 AM Graham Knop ***@***.***> wrote: That modules is included in the t/lib directory. — Reply to this email directly, view it on GitHub <#183 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR5IZK6MLQYLNJOHKBHBVDXC2SCVANCNFSM6AAAAAAXFH3NOQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

Openstreetmapler · 2023-04-26T06:21:35Z

Entering the command prove -lvr t/content_negotiation.t outputs these errors (probably because the files are missing or me using perlbrew):

Cannot detect source of 't/content_negotiation.t'! at /home/nasaruk/perl5/perlbrew/perls/perl-5.22.3/lib/5.22.3/TAP/Parser/IteratorFactory.pm line 261.
	TAP::Parser::IteratorFactory::detect_source(TAP::Parser::IteratorFactory=HASH(0x55b71da73840), TAP::Parser::Source=HASH(0x55b71da55a30)) called at /home/nasaruk/perl5/perlbrew/perls/perl-5.22.3/lib/5.22.3/TAP/Parser/IteratorFactory.pm line 211
	TAP::Parser::IteratorFactory::make_iterator(TAP::Parser::IteratorFactory=HASH(0x55b71da73840), TAP::Parser::Source=HASH(0x55b71da55a30)) called at /home/nasaruk/perl5/perlbrew/perls/perl-5.22.3/lib/5.22.3/TAP/Parser.pm line 472
	TAP::Parser::_initialize(TAP::Parser=HASH(0x55b71da59f10), HASH(0x55b71d828e48)) called at /home/nasaruk/perl5/perlbrew/perls/perl-5.22.3/lib/5.22.3/TAP/Object.pm line 55
	TAP::Object::new("TAP::Parser", HASH(0x55b71d828e48)) called at /home/nasaruk/perl5/perlbrew/perls/perl-5.22.3/lib/5.22.3/TAP/Object.pm line 130
	TAP::Object::_construct(TAP::Harness=HASH(0x55b71d308220), "TAP::Parser", HASH(0x55b71d828e48)) called at /home/nasaruk/perl5/perlbrew/perls/perl-5.22.3/lib/5.22.3/TAP/Harness.pm line 852
	TAP::Harness::make_parser(TAP::Harness=HASH(0x55b71d308220), TAP::Parser::Scheduler::Job=HASH(0x55b71d75ee90)) called at /home/nasaruk/perl5/perlbrew/perls/perl-5.22.3/lib/5.22.3/TAP/Harness.pm line 651
	TAP::Harness::_aggregate_single(TAP::Harness=HASH(0x55b71d308220), TAP::Parser::Aggregator=HASH(0x55b71d757948), TAP::Parser::Scheduler=HASH(0x55b71d75ee30)) called at /home/nasaruk/perl5/perlbrew/perls/perl-5.22.3/lib/5.22.3/TAP/Harness.pm line 743
	TAP::Harness::aggregate_tests(TAP::Harness=HASH(0x55b71d308220), TAP::Parser::Aggregator=HASH(0x55b71d757948), "t/content_negotiation.t") called at /home/nasaruk/perl5/perlbrew/perls/perl-5.22.3/lib/5.22.3/TAP/Harness.pm line 558
	TAP::Harness::__ANON__() called at /home/nasaruk/perl5/perlbrew/perls/perl-5.22.3/lib/5.22.3/TAP/Harness.pm line 571
	TAP::Harness::runtests(TAP::Harness=HASH(0x55b71d308220), "t/content_negotiation.t") called at /home/nasaruk/perl5/perlbrew/perls/perl-5.22.3/lib/5.22.3/App/Prove.pm line 546
	App::Prove::_runtests(App::Prove=HASH(0x55b71d2dfc98), HASH(0x55b71d71f460), "t/content_negotiation.t") called at /home/nasaruk/perl5/perlbrew/perls/perl-5.22.3/lib/5.22.3/App/Prove.pm line 504
	App::Prove::run(App::Prove=HASH(0x55b71d2dfc98)) called at /home/nasaruk/perl5/perlbrew/perls/perl-5.22.3/bin/prove line 13

perl-catalyst-sync · 2023-04-30T23:25:14Z

Hi, you run prove from the root of your github checkout. If you need help let me know some times you can do a short Zoom session and I will review it with you. I 'm (GMT-5) or US Central timezone. -jn

On Wed, Apr 26, 2023 at 1:21 AM Openstreetmapler ***@***.***> wrote: Entering the command prove -lvr t/content_negotiation.t outputs these

errors (probably because the files are missing or me using perlbrew):

Cannot detect source of 't/content_negotiation.t'! at

/home/nasaruk/perl5/perlbrew/perls/perl-5.22.3/lib/5.22.3/TAP/Parser/IteratorFactory.pm line 261.

TAP::Parser::IteratorFactory::detect_source(TAP::Parser::IteratorFactory=HASH(0x55b71da73840), TAP::Parser::Source=HASH(0x55b71da55a30)) called at /home/nasaruk/perl5/perlbrew/perls/perl-5.22.3/lib/5.22.3/TAP/Parser/IteratorFactory.pm line 211

TAP::Parser::IteratorFactory::make_iterator(TAP::Parser::IteratorFactory=HASH(0x55b71da73840), TAP::Parser::Source=HASH(0x55b71da55a30)) called at /home/nasaruk/perl5/perlbrew/perls/perl-5.22.3/lib/5.22.3/TAP/Parser.pm line 472

TAP::Parser::_initialize(TAP::Parser=HASH(0x55b71da59f10),

HASH(0x55b71d828e48)) called at /home/nasaruk/perl5/perlbrew/perls/perl-5.22.3/lib/5.22.3/TAP/Object.pm line 55

TAP::Object::new("TAP::Parser", HASH(0x55b71d828e48)) called at

/home/nasaruk/perl5/perlbrew/perls/perl-5.22.3/lib/5.22.3/TAP/Object.pm line 130

TAP::Object::_construct(TAP::Harness=HASH(0x55b71d308220), "TAP::Parser",

HASH(0x55b71d828e48)) called at /home/nasaruk/perl5/perlbrew/perls/perl-5.22.3/lib/5.22.3/TAP/Harness.pm line 852

TAP::Harness::make_parser(TAP::Harness=HASH(0x55b71d308220),

TAP::Parser::Scheduler::Job=HASH(0x55b71d75ee90)) called at /home/nasaruk/perl5/perlbrew/perls/perl-5.22.3/lib/5.22.3/TAP/Harness.pm line 651

TAP::Harness::_aggregate_single(TAP::Harness=HASH(0x55b71d308220),

TAP::Parser::Aggregator=HASH(0x55b71d757948), TAP::Parser::Scheduler=HASH(0x55b71d75ee30)) called at /home/nasaruk/perl5/perlbrew/perls/perl-5.22.3/lib/5.22.3/TAP/Harness.pm line 743

TAP::Harness::aggregate_tests(TAP::Harness=HASH(0x55b71d308220),

TAP::Parser::Aggregator=HASH(0x55b71d757948), "t/content_negotiation.t") called at /home/nasaruk/perl5/perlbrew/perls/perl-5.22.3/lib/5.22.3/TAP/Harness.pm line 558

TAP::Harness::__ANON__() called at

/home/nasaruk/perl5/perlbrew/perls/perl-5.22.3/lib/5.22.3/TAP/Harness.pm line 571

TAP::Harness::runtests(TAP::Harness=HASH(0x55b71d308220),

"t/content_negotiation.t") called at /home/nasaruk/perl5/perlbrew/perls/perl-5.22.3/lib/5.22.3/App/Prove.pm line 546

App::Prove::_runtests(App::Prove=HASH(0x55b71d2dfc98),

HASH(0x55b71d71f460), "t/content_negotiation.t") called at /home/nasaruk/perl5/perlbrew/perls/perl-5.22.3/lib/5.22.3/App/Prove.pm line 504

App::Prove::run(App::Prove=HASH(0x55b71d2dfc98)) called at

/home/nasaruk/perl5/perlbrew/perls/perl-5.22.3/bin/prove line 13

…

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented. Message ID: ***@***.*** com>

Openstreetmapler · 2023-05-02T07:13:08Z

I don’t have a GitHub checkout. I am running a Catalyst project in a local git repository.

perl-catalyst-sync · 2023-05-02T12:17:35Z

same thing

…

On Tue, May 2, 2023 at 2:13 AM Openstreetmapler ***@***.***> wrote: I don’t have a GitHub checkout. I am running a Catalyst project in a local git repository. — Reply to this email directly, view it on GitHub <#183 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR5IZO55QGQGEUJL5IJUMDXECXY5ANCNFSM6AAAAAAXFH3NOQ> . You are receiving this because you commented.Message ID: ***@***.***>

perl-catalyst-sync · 2023-05-02T12:18:06Z

you run prove from the directory that has the 't' directory in it

…

On Tue, May 2, 2023 at 7:17 AM john napiorkowski ***@***.***> wrote: same thing On Tue, May 2, 2023 at 2:13 AM Openstreetmapler ***@***.***> wrote: > I don’t have a GitHub checkout. I am running a Catalyst project in a > local git repository. > > — > Reply to this email directly, view it on GitHub > <#183 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAR5IZO55QGQGEUJL5IJUMDXECXY5ANCNFSM6AAAAAAXFH3NOQ> > . > You are receiving this because you commented.Message ID: > ***@***.***> >

Openstreetmapler · 2023-05-02T15:05:42Z

Where is that directory?

perl-catalyst-sync · 2023-05-02T15:45:46Z

should be the directory that has the .git directory for the git checkout -jn

…

On Tue, May 2, 2023 at 10:05 AM Openstreetmapler ***@***.***> wrote: Where is that directory? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: ***@***.***>

Openstreetmapler · 2023-05-04T08:55:41Z

No matter where I run the command (even in the Catalyst project’s root folder), it outputs the errors.

There is a t folder in my project folder, but only with these files:

01app.t
02pod.t
03podcoverage.t

Openstreetmapler · 2023-05-10T06:51:27Z

No matter where I run the command (even in the Catalyst project’s root folder), it outputs the errors.

There is a t folder in my project folder, but only with these files:

01app.t

02pod.t

03podcoverage.t

I tried running the command with content_negotiation.t added to the t folder and ran the command – but the TestContentNegotiation module is nowhere to be found in @INC!

At this point, it feels like this issue is impossible to solve and I just have to re-install Catalyst. 😞

haarg · 2023-05-10T13:04:00Z

TestContentNegotiation is not installed with Catalyst. It is included with the Catalyst-Runtime git repository or with the CPAN release tarball. The test scripts and their related modules do not get installed.

git clone https://github.com/perl-catalyst/catalyst-runtime.git
cd catalyst-runtime
prove -lvr t/content_negotiation.t

Openstreetmapler · 2023-05-19T09:44:11Z

Thanks a lot for the info! However, due to vacation, I won’t be able to try it out until May 31st since the issue is work-related in my case.

If something else had already read from the filehandle, we'd get nothing, and end up throwing an error like: ``` [error] Caught exception in engine "Error Parsing POST 'undef', Error: malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "(end of string)") at /home/davidp/perl5/lib/perl5/Catalyst.pm line 4092, <$fh> chunk 11." ``` ... that sounds like we got an empty POST or something, but in fact the problem was that a plugin had caused the request body to have already been read, so the filehandle wasn't at the beginning. This seek means that we will read and parse the whole body content as intended, even if something had already read from the filehandle. I think this will also likely solve perl-catalyst#183.

bigpresh mentioned this issue Sep 14, 2023

Rewind body filehandle before reading JSON #186

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

getline method is inoperative and maybe outdated #183

getline method is inoperative and maybe outdated #183

Openstreetmapler commented Apr 20, 2023

jjn1056 commented Apr 20, 2023

Openstreetmapler commented Apr 21, 2023

jjn1056 commented Apr 21, 2023

Openstreetmapler commented Apr 24, 2023 •

edited

Loading

haarg commented Apr 24, 2023

perl-catalyst-sync commented Apr 24, 2023 via email

Openstreetmapler commented Apr 26, 2023

perl-catalyst-sync commented Apr 30, 2023 via email

Openstreetmapler commented May 2, 2023

perl-catalyst-sync commented May 2, 2023 via email

perl-catalyst-sync commented May 2, 2023 via email

Openstreetmapler commented May 2, 2023

perl-catalyst-sync commented May 2, 2023 via email

Openstreetmapler commented May 4, 2023

Openstreetmapler commented May 10, 2023

haarg commented May 10, 2023

Openstreetmapler commented May 19, 2023

getline method is inoperative and maybe outdated #183

getline method is inoperative and maybe outdated #183

Comments

Openstreetmapler commented Apr 20, 2023

jjn1056 commented Apr 20, 2023

Openstreetmapler commented Apr 21, 2023

jjn1056 commented Apr 21, 2023

Openstreetmapler commented Apr 24, 2023 • edited Loading

haarg commented Apr 24, 2023

perl-catalyst-sync commented Apr 24, 2023 via email

Openstreetmapler commented Apr 26, 2023

perl-catalyst-sync commented Apr 30, 2023 via email

Openstreetmapler commented May 2, 2023

perl-catalyst-sync commented May 2, 2023 via email

perl-catalyst-sync commented May 2, 2023 via email

Openstreetmapler commented May 2, 2023

perl-catalyst-sync commented May 2, 2023 via email

Openstreetmapler commented May 4, 2023

Openstreetmapler commented May 10, 2023

haarg commented May 10, 2023

Openstreetmapler commented May 19, 2023

Openstreetmapler commented Apr 24, 2023 •

edited

Loading