Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify all stages of an image [which rickshaw sourced/built with workshop] are not stale #531

Closed
atheurer opened this issue Aug 1, 2024 · 3 comments
Assignees
Labels

Comments

@atheurer
Copy link
Contributor

atheurer commented Aug 1, 2024

It is possible that the "base" image, the container image specified in a userenv, can be updated without our knowledge. For example, a stream:9 image which now has libraries updated for bug fixes, or a nvidia-cuda:latest image which has python libraries updated. When we expired images every two weeks, this was not a big issue, but now that we don't expire for a year, we may run into situations where the base image is "stale".

To remedy this, we need to, for all stages in a image, compare the manifest of the container image we have to the manifest of the container image at its source, and if there is a difference, rebuild (with pull --always) the image. This needs to be done even if the final image:tag we need matches locally or even in the container registry.

@k-rister
Copy link
Contributor

k-rister commented Aug 1, 2024

I've looked into this a bit and I don't think it would be terribly difficult to add the digest of the image that we are basing a build off of to the config dump (that is then used by rickshaw to compute it's tags). If that base image changes then it's digest will change and then the correspond config dump will change and the calculated tag would change.

@k-rister k-rister moved this from Queued to Todo in Crucible Tracking Aug 5, 2024
@k-rister k-rister moved this from Todo to In Progress in Crucible Tracking Aug 6, 2024
@k-rister
Copy link
Contributor

k-rister commented Aug 9, 2024

Lots of work being done for this issue here: perftool-incubator/workshop#84

@k-rister
Copy link
Contributor

This is taken care of by the build-policy property in the userenv.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Crucible Tracking Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants