You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm currently having to deal with url validation in our ActiveRecord models and I found this gem that feels a useful one to encapsulate that functionality.
Btw, I've just realised that the validation for no_local url's is quite simple as it just checks that the host contains a ., but it doesn't really care about aspects like the position of the dot, or the existence of www.
So it considers following urls as valid ones: http://.whatever http://www.
Is there any reason for that?
Would you accept a PR with extra checks?
Cheers!
The text was updated successfully, but these errors were encountered:
Hi guys,
I'm currently having to deal with url validation in our
ActiveRecord
models and I found this gem that feels a useful one to encapsulate that functionality.Btw, I've just realised that the validation for
no_local
url's is quite simple as it just checks that the host contains a.
, but it doesn't really care about aspects like the position of the dot, or the existence ofwww
.So it considers following urls as valid ones:
http://.whatever
http://www.
Is there any reason for that?
Would you accept a PR with extra checks?
Cheers!
The text was updated successfully, but these errors were encountered: