Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About no_local: true validation complexity #59

Open
aviscasillas opened this issue Oct 4, 2017 · 0 comments
Open

About no_local: true validation complexity #59

aviscasillas opened this issue Oct 4, 2017 · 0 comments

Comments

@aviscasillas
Copy link

Hi guys,

I'm currently having to deal with url validation in our ActiveRecord models and I found this gem that feels a useful one to encapsulate that functionality.

Btw, I've just realised that the validation for no_local url's is quite simple as it just checks that the host contains a ., but it doesn't really care about aspects like the position of the dot, or the existence of www.

So it considers following urls as valid ones:
http://.whatever
http://www.

Is there any reason for that?
Would you accept a PR with extra checks?

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant