Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

K8SPXC-1542: Fix Azure binlog upload for large files #1848

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

K8SPXC-1542: Fix Azure binlog upload for large files #1848

wants to merge 5 commits into from
+117 −12

Conversation

dcaputo-harmoni
Copy link
Contributor

@dcaputo-harmoni dcaputo-harmoni commented Oct 16, 2024 •
edited by pull-request-badge bot
Loading

Fixes #1847

@pull-request-size pull-request-size bot added the size/XS 0-9 lines label Oct 16, 2024
@egegunes egegunes self-assigned this Oct 16, 2024
@egegunes
Copy link
Contributor

@dcaputo-harmoni tests are failing because GKE 1.27 is removed. I'll ping you to ask rebase after #1849 merged.

@dcaputo-harmoni
Copy link
Contributor Author

@egegunes No problem, just let me know when

nmarukovich
nmarukovich requested changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@nmarukovich nmarukovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make concurrency value configurable.

@egegunes egegunes assigned nmarukovich and unassigned egegunes Nov 11, 2024
@egegunes
Copy link
Contributor

@nmarukovich please create a jira ticket and let's take over this PR.

@egegunes egegunes added this to the v1.16.0 milestone Nov 19, 2024
@hors hors modified the milestones: v1.16.0, v1.17.0 Dec 3, 2024
@pull-request-size pull-request-size bot added size/L 100-499 lines and removed size/XS 0-9 lines labels Dec 15, 2024
@dcaputo-harmoni
Copy link
Contributor Author

I added in some proposed changes to make both concurrency and block size configurable for Azure storage endpoints, let me know if this is along the lines of what you were thinking. I'm running into issues now where larger files require even larger block size / concurrency settings so I think this will be useful to be configurable via yaml.

@egegunes egegunes changed the title GITHUB-ISSUE-1847: Fix Azure binlog upload for large files K8SPXC-1542: Fix Azure binlog upload for large files Jan 6, 2025
@hors hors requested a review from gkech as a code owner January 13, 2025 16:09
@JNKPercona
Copy link
Collaborator

Test name Status
affinity-8-0 passed
auto-tuning-8-0 passed
cross-site-8-0 passed
custom-users-8-0 passed
demand-backup-cloud-8-0 passed
demand-backup-encrypted-with-tls-8-0 passed
demand-backup-8-0 passed
haproxy-5-7 passed
haproxy-8-0 passed
init-deploy-5-7 passed
init-deploy-8-0 passed
limits-8-0 passed
monitoring-2-0-8-0 passed
one-pod-5-7 passed
one-pod-8-0 passed
pitr-8-0 passed
pitr-gap-errors-8-0 passed
proxy-protocol-8-0 passed
proxysql-sidecar-res-limits-8-0 passed
pvc-resize-5-7 passed
pvc-resize-8-0 passed
recreate-8-0 passed
restore-to-encrypted-cluster-8-0 passed
scaling-proxysql-8-0 passed
scaling-8-0 passed
scheduled-backup-5-7 passed
scheduled-backup-8-0 passed
security-context-8-0 passed
smart-update1-8-0 passed
smart-update2-8-0 passed
storage-8-0 passed
tls-issue-cert-manager-ref-8-0 passed
tls-issue-cert-manager-8-0 passed
tls-issue-self-8-0 passed
upgrade-consistency-8-0 passed
upgrade-haproxy-5-7 passed
upgrade-haproxy-8-0 passed
upgrade-proxysql-5-7 passed
upgrade-proxysql-8-0 passed
users-5-7 passed
users-8-0 passed
validation-hook-8-0 passed
We run 42 out of 42

commit: 09b4902
image: perconalab/percona-xtradb-cluster-operator:PR-1848-09b4902b

@dcaputo-harmoni
Copy link
Contributor Author

Hi @hors just want to check in on this one, let me know if I can help get this resolved - it's an important feature for anyone running in an Azure production environment....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmarukovich nmarukovich nmarukovich requested changes

@hors hors Awaiting requested review from hors hors is a code owner

@egegunes egegunes Awaiting requested review from egegunes egegunes is a code owner

@inelpandzic inelpandzic Awaiting requested review from inelpandzic

@pooknull pooknull Awaiting requested review from pooknull pooknull is a code owner

@gkech gkech Awaiting requested review from gkech gkech is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@nmarukovich nmarukovich

Labels
community size/L 100-499 lines
Projects
None yet
Milestone
v1.17.0
Development

Successfully merging this pull request may close these issues.

Large PITR binlog uploads to Azure storage timeout with "Context deadline exceeded"
5 participants
@dcaputo-harmoni @egegunes @JNKPercona @nmarukovich @hors