Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]split user and password from uri #559

Closed
naughtyGitCat opened this issue Sep 13, 2022 · 4 comments · Fixed by #560
Closed

[feature]split user and password from uri #559

naughtyGitCat opened this issue Sep 13, 2022 · 4 comments · Fixed by #560

Comments

@naughtyGitCat
Copy link
Contributor

Is your feature request related to a problem? Please describe.
expose monitoring mongo instance URI will be helpful when handling problems, but exposing user pass is insecure

Describe the solution you'd like
user and pass supply in env variables

Describe alternatives you've considered
use --remark or --note to add extra info, such as --note=IP:PORT

@denisok
Copy link
Contributor

denisok commented Sep 13, 2022

similar request is in #380 . As a secure alternative so far you can use tls connection with --web.config which is Prometheus TLS config file

@denisok
Copy link
Contributor

denisok commented Sep 14, 2022

hm. I mixed up the things, --web.config is the parameter for exporter itself. It will not help with connection to mongo. So yeah, concern is quite critical we need to address it.

@denisok
Copy link
Contributor

denisok commented Sep 14, 2022

to make it clear --web-config is for exporter itself, but you still use tls in a connection URI: tls=truetlsCertificateKeyFile=Server.pem&tlsCAFile=ca.pem in connection string instead of password.

@naughtyGitCat
Copy link
Contributor Author

thanks, TLS may be another way to secure the exporter, and seems a little inconvenient to me. we want to expose the monitoring DB instance URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants