Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventPositionExecution should record the fees taken by the position #4821

Open
hdevalence opened this issue Aug 15, 2024 · 0 comments
Open
Labels
needs-refinement unclear, incomplete, or stub issue that needs work

Comments

@hdevalence
Copy link
Member

Is your feature request related to a problem? Please describe.

Currently, there's not an easy way to collect data on how much fees each position is earning. For instance, https://dex.penumbra.sevenseas.capital/lp/plpid1c3suelz9xyc4hwh6s0375xrwjkgq9f57z28sy95aj4q6cqu4tjcsfjx8jn is a highly profitable position, but this requires manual inspection.

Describe the solution you'd like

The EventPositionExecution should record data about what fees were claimed by the position during execution. This information is not immediately available (because of the formulation of \gamma as a percentage applied to the inputs) but should be computable from the information that is present.

Ideally, this change could be backported to the 0.79.x branch so that event databases can be regenerated with this field and it can be applied to historical data as well.

@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-refinement unclear, incomplete, or stub issue that needs work
Projects
None yet
Development

No branches or pull requests

1 participant