Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assets table to portfolio page #220

Closed
grod220 opened this issue Dec 16, 2024 · 2 comments · Fixed by #233
Closed

Add assets table to portfolio page #220

grod220 opened this issue Dec 16, 2024 · 2 comments · Fixed by #233
Assignees
Labels

Comments

@grod220
Copy link
Contributor

grod220 commented Dec 16, 2024

  • Queries view service
  • Assets filtered by sub-account selected
  • Actions correspond to swap in/out
  • Likely need to implement new backend endpoint for price
Screenshot 2024-12-16 at 10 47 49 AM

Figma reference: https://www.figma.com/design/xWsVprkEgEihweVN9isrGQ/DEX-(Incl.-UI-Lib)?node-id=3658-145100&p=f&t=5zoqHAAlNcIDzQhM-0

@grod220 grod220 added the ui label Dec 16, 2024
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra web Dec 16, 2024
@grod220 grod220 moved this to 📝 Todo in Labs web Dec 16, 2024
@grod220 grod220 added this to Labs web Dec 16, 2024
@TalDerei
Copy link
Contributor

TalDerei commented Dec 16, 2024

re-price: all the stats info we need are already available from pindexer, and I’ve implemented a shared helper that performs these conversions as part of #188, which we can review later.

I’d be interested in taking on this ticket.

@TalDerei TalDerei moved this from 📝 Todo to 🏗 In progress in Labs web Dec 19, 2024
@TalDerei TalDerei assigned vacekj and unassigned TalDerei Jan 7, 2025
@TalDerei
Copy link
Contributor

TalDerei commented Jan 7, 2025

@vacekj note that the new backend endpoint for price is already in #223, so you can just stub that for now.

@TalDerei TalDerei moved this from 🏗 In progress to 📝 Todo in Labs web Jan 7, 2025
@vacekj vacekj moved this from 📝 Todo to 🏗 In progress in Labs web Jan 7, 2025
@vacekj vacekj linked a pull request Jan 8, 2025 that will close this issue
@vacekj vacekj moved this from 🏗 In progress to 🔎 In review in Labs web Jan 9, 2025
@erwanor erwanor moved this from 🗄️ Backlog to 🏗 In progress in Penumbra web Jan 9, 2025
@github-project-automation github-project-automation bot moved this from 🔎 In review to ✅ Done in Labs web Jan 14, 2025
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Penumbra web Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants