Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collator heading overlaps #80

Closed
prayagd opened this issue Mar 14, 2023 · 5 comments · Fixed by #202
Closed

Collator heading overlaps #80

prayagd opened this issue Mar 14, 2023 · 5 comments · Fixed by #202
Assignees
Labels
type:bug Something isn't working

Comments

@prayagd
Copy link
Collaborator

prayagd commented Mar 14, 2023

Describe the bug

On the collator dashboard i see side scroll and the collator heading overlaps other headings

Reproduction

Steps to reproduce the behavior:

  1. Go to /collator on portal
  2. Scroll left and right
  3. You will see the collator heading overlaps over other heading

Expected behavior

There should be no overlap of the headings over each other and also no side scroll, ideally the user should be able to see the entire table without scrolling.

Screenshots

Screenshot 2023-03-14 at 12 59 28 PM

Desktop (please complete the following information):

  • OS: iOS
  • Browser both chrome[111.0.5563.64] and safari[16.1]
@prayagd
Copy link
Collaborator Author

prayagd commented Mar 14, 2023

cc @gonzamontiel

@gonzamontiel
Copy link
Contributor

hey @prayagd, can you please check that after we merged #70 this is still happening?
For me it looks like this in staging:
Screenshot from 2023-03-15 00 23 52

Screenshot from 2023-03-15 00 23 25

If it still happens, we need to ask someone with MacOS that can reproduce it, @ebma @nejcm ?

@github-project-automation github-project-automation bot moved this from Backlog to Done in Pendulum Board Mar 14, 2023
@gonzamontiel gonzamontiel reopened this Mar 14, 2023
@gonzamontiel
Copy link
Contributor

I didn't mean to close it, let's check if the bug in macOS is still there. Also @prayagd, if it still happens to you, can you edit the title to add a tag like [MacOS] or a label like macos-only?

@ebma
Copy link
Member

ebma commented Mar 21, 2023

Can confirm that this can happen. But it only happens when I zoom in to 110%.
image

Another problem is that the table does not 'responsively' adjust to zooming. Even in 100% zoom (so no zoom at all but the default value), the table is scrollable which I think is a bit annoying. (As you can see on the screenshot the buttons are not entirely visible and I can scroll to the right). I would expect the table to show without scrolling by default but I'm not sure how easy it is to achieve.
image

@nejcm nejcm self-assigned this Jun 28, 2023
@nejcm nejcm linked a pull request Jun 28, 2023 that will close this issue
@nejcm
Copy link
Contributor

nejcm commented Jun 28, 2023

The problem is some css from the daisy lib. It has some table headers set as position sticky.

@ebma ebma closed this as completed in #202 Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants