-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show 24h and 7d APR on the swap pools UI #590
Comments
Hey team! Please add your planning poker estimate with Zenhub @ebma @Sharqiewicz @TorstenStueber |
The indexer currently only exposes a general |
@prayagd What is the definition of a 24 hour and a 7 day APR? It's an oxymoron, isn't it as APR is an annual rate? Anyway, whatever that means. We calculate the APR extrapolated from the gains within the last seven days. |
What we are extrapolating using APR for 7 days we want to do the same for 24h |
Even for doing this we need to make changes to the indexer? |
Well the apr field is currently exposed by the indexer. And the nabla team also gets it from their indexer, so I think it makes most sense to do this. I found the relevant lines of code that describe the calculation they do for the 24h and 7d apr here. So IMO we should add similar changes to our indexer and then access those fields in the portal. Thus we'd need one extra ticket in pendulum-squids. |
Okay, understood. But is this high priority for us? I would consider it more a nice to have – we don't need to copy every aspects of the Nabla UI at this stage of the project. |
Not a high priority, good to have in the backlog |
@pendulum-chain/product as I pointed out, this ticket requires changes to the indexer before it can be worked on. I created the ticket pendulum-chain/pendulum-squids#74 for you, please prioritize it accordingly. |
@pendulum-chain/product even though this ticket is blocked by another ticket, shall we not move it to Ready, as it is ready? |
Context
Currently there is only 7d APR shown on the swap pools screen, this ticket is to show both 24h and 7d APR
Todo
Note
The text was updated successfully, but these errors were encountered: