Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable PEN (Sol Peruano Digital) and ARS (Peso Digital) as Spacewalk asset on the portal on Pendulum #544

Closed
6 tasks
annatekl opened this issue Aug 30, 2024 · 18 comments · Fixed by #593
Closed
6 tasks
Assignees

Comments

@annatekl
Copy link

annatekl commented Aug 30, 2024

Context

We are planning to PEN (Sol Peruano Digital) and ARS (Peso Digital) to Spacewalk assets. We need to enable assets on the portal and the dashboard once the root transaction is completed.

Asset

  • PEN (Sol Peruano Digital)
  • ARS (Peso Digital)

asset details

Asset Icons:
ARS - https://static.anclap.com/coin/ars.png
PEN - https://static.anclap.com/coin/pen.png

Requirements

  • Add PEN (Sol Peruano Digital) to the portal dashboard
  • Add pricing for PEN
  • Add icon for PEN
  • Add ARS (Peso Digital) to the portal dashboard
  • Add pricing for ARS - Binance
  • Add icon for ARS
@annatekl annatekl added draft Work in progress and removed draft Work in progress labels Aug 30, 2024
@annatekl
Copy link
Author

annatekl commented Sep 2, 2024

Hey team! Please add your planning poker estimate with Zenhub @ebma @Sharqiewicz

@ebma
Copy link
Member

ebma commented Sep 2, 2024

@Sharqiewicz all we need to do for this is to make sure that the icons are available for the respective new currencies. The Spacewalk vault dropdown and asset dashboard should show these tokens automatically one a) a vault is registered and b) the asset registry metadata for these values is added on chain.

@Sharqiewicz
Copy link
Collaborator

Thanks @ebma for explaining :)

@annatekl
Copy link
Author

annatekl commented Sep 5, 2024

Icons updated

@vadaynujra
Copy link

@ebma we don't have the vault creation tickets for the new assets. Since that would also require provisioning for some liquidity / collateral, will look into it later.

@ebma
Copy link
Member

ebma commented Sep 19, 2024

Should we add a label to this ticket that it's blocked or in draft?

@vadaynujra vadaynujra added the draft Work in progress label Sep 25, 2024
@prayagd
Copy link
Collaborator

prayagd commented Sep 26, 2024

Should we add a label to this ticket that it's blocked or in draft?

@vadaynujra are there any more tickets required apart from this ?

@prayagd
Copy link
Collaborator

prayagd commented Sep 26, 2024

There is also other ticket, i assume this is for setting thresholds and adding liquidity

@vadaynujra
Copy link

@ebma what is the source of pricing for Spacewalk related assets that we can specify in the description? It's more interesting for ARS which has 2 prices.

@ebma
Copy link
Member

ebma commented Sep 26, 2024

We are querying the prices from polygon.io, if you log into the dashboard you can also check the results with this query. To me it seems like the price is similar to this yahoo ticker.

@prayagd
Copy link
Collaborator

prayagd commented Sep 30, 2024

@vadaynujra can you share the price we need for the ARS asset and also is there any preference with the PEN asset?

@vadaynujra
Copy link

For Argentinian Peso (ARS), the anchor uses the Blue Rate and so we will go with the same. Checking the price of the asset on the Stellar side confirms the same (screenshot).
@ebma @prayagd using this information, can you find the specific feed on Polygon?

image

The Peruvian Sol (PEN) doesn't have this challenge and we can use the standard rate.

@ebma
Copy link
Member

ebma commented Oct 1, 2024

That's a problem. When I query the price from polygon.io for USD to ARS, I get an exchange rate of 1 USD = 968.7406 ARS. I checked all tickers and they don't have any ticker for the blue dollar.

I don't know how niche this blue dollar is but the only way I see to get the exchange rate on chain right now is to handle custom handling to the batching server. We should have already clarified this before setting up the PEN and ARS price feeds we already added. Because now we probably have to unregister the ARS price again and replace it with ARSB.

@vadaynujra
Copy link

to handle custom handling to the batching server

How would it be handed? Different price source than Polygon e.g. Stellar AMM or some other off chain option? Rr something else?

We should have already clarified this before setting up the PEN and ARS price feeds we already added.

True, especially since we always knew about this dual price for ARS. What does unregistering the price mean? Not the same as the asset registry right?

@ebma
Copy link
Member

ebma commented Oct 1, 2024

Yes, we first have to find a different provider where we can reliably source the USD/ARSB price from. I didn't see many, but we have to look into this. I doubt that Polygon.io would be willing to add that for us.

What does unregistering the price mean? Not the same as the asset registry right?

This depends how we want to set it up. In theory, we can cut some corners with the on-chain configuration and leave everything as is by only changing the batching server to serve the ARSB price instead of ARS. While not technically correct, I guess it would be fine for our use case. This assumes that we never ever want to have access to both ARS and ARSB prices on-chain.

@vadaynujra
Copy link

Found a feed on Binance spot rate: https://www.binance.com/en/trade/USDT_ARS?type=spot

@vadaynujra
Copy link

vadaynujra commented Oct 4, 2024

@prayagd to update the icons.

@prayagd
Copy link
Collaborator

prayagd commented Oct 4, 2024

@prayagd update the icons.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants