Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge back to stellar - max amount chosen by the user allow for the amount that is incompatible #503

Closed
2 tasks
annatekl opened this issue Jun 25, 2024 · 6 comments · Fixed by #506
Closed
2 tasks
Assignees
Labels
type:bug Something isn't working

Comments

@annatekl
Copy link

annatekl commented Jun 25, 2024

Context

When choosing 'Back to Stellar' and entering 'Max,' the amount prefilled by the system is half the available funds and correct, but the error message after the transaction is signed indicates that the amount is incompatible.

Reproduction

Steps to reproduce the behaviour:

  1. Go to the Spacewalk bridge.
  2. Click on "Back to Stellar."
  3. Click on 'Max' to prefill the maximum available amount.
  4. Sign the transaction.
  5. See error message: "Transaction failed with errors: currency.Incompatible/Amount: The amount is incompatible."

Expected behavior

  • The system should choose compatible amount when user clicks "Max" and the transaction should succeed.
  • The system should prefill the maximum available amount with the correct decimal number limited to 7.

Screenshots

Screenshot 2024-06-25 at 15 47 59
@annatekl annatekl added the type:bug Something isn't working label Jun 25, 2024
@annatekl
Copy link
Author

Hey team! Please add your planning poker estimate with Zenhub @ebma @Sharqiewicz

@ebma
Copy link
Member

ebma commented Jun 25, 2024

@Sharqiewicz this should be an easy fix. We should simply not allow more than 7 decimals in that input field.

@annatekl
Copy link
Author

ticket updated @ebma

@vadaynujra
Copy link

@annatekl can you add the other bugs found on the To Stellar flow into this ticket too?

@annatekl
Copy link
Author

@ebma can we fix in this ticket:

  • Redirect Issue: The "View in Progress" action is currently redirecting users to a "Not Found" page instead of the intended "Transactions" page.
  • Error Message for Invalid Input: When a user enters 0, no error message is displayed. We expect an error message stating, "You need to enter a positive number."

@vadaynujra
Copy link

@annatekl the ticket has already been worked upon and asked for a product review / test yesterday. Could you create new bug ticket for the additional bugs. If we want to get it included, it's best to include it in the ticket description before the tech team starts working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
4 participants