Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show BSP and swap balance 0 when wallet not connected #469

Closed
prayagd opened this issue May 28, 2024 · 3 comments · Fixed by #477
Closed

Show BSP and swap balance 0 when wallet not connected #469

prayagd opened this issue May 28, 2024 · 3 comments · Fixed by #477
Assignees
Labels
type:bug Something isn't working

Comments

@prayagd
Copy link
Collaborator

prayagd commented May 28, 2024

Describe the bug

Currently when the wallet is not connected to the portal, the swap UI and the BSP UI loads continuously showing a animation

Reproduction

Steps to reproduce the behavior:

  1. Go to https://portal.pendulumchain.org/foucoco/nabla/backstop-pools
  2. See the loading animation
  3. Same applies for the swap UI, the balances component also keeps loading

Expected behavior

Nothing should be displayed as the wallet is not connected to the Portal UI

Screenshots

Screenshot 2024-05-28 at 4 02 49 PM Screenshot 2024-05-28 at 4 03 01 PM

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: Chrome, Firefox
@prayagd prayagd added the type:bug Something isn't working label May 28, 2024
@TorstenStueber
Copy link
Member

TorstenStueber commented May 28, 2024

This is not necessarily a bug in my opinion. If there is no wallet connected, I think also 0 is just wrong and could be potentially confusing – at least for me. There is just no meaningful number.

I agree that showing a loading animation does not make a lot of sense either and is unintuitive.

I would show some UI instead that indicates to "connect a wallet".

@TorstenStueber
Copy link
Member

Hey team! Please add your planning poker estimate with Zenhub @ebma @Sharqiewicz

@prayagd
Copy link
Collaborator Author

prayagd commented May 29, 2024

@TorstenStueber based on your response, i checked the uniswap UI. They prefer to show nothing, i think so that too works instead of the constant loading block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants