Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approve button does not appear again for new swap after successful swap #467

Open
prayagd opened this issue May 28, 2024 · 0 comments
Open
Labels
draft Work in progress

Comments

@prayagd
Copy link
Collaborator

prayagd commented May 28, 2024

Describe the bug

When a user completes a Nabla swap and now changes the source token and does not change the source amount, the Approve button does not show up and directly a Swap button is displayed on clicking Swap button the transaction fails.

Reproduction

Steps to reproduce the behavior:

  1. Go to https://portal.pendulumchain.org/foucoco/nabla/swap
  2. Select any source token and destination token and do a swap
  3. Now change the source token and dont change the amount, the UI shows a swap button
  4. On clicking the Swap button, the UI throws and error

Expected behavior

Approve button should show before every new swap to be done assuming the Approval was not done for the specific pair and amount

Screenshots

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

Add any other context about the problem here.

@prayagd prayagd added the draft Work in progress label May 28, 2024
@prayagd prayagd changed the title Approve button missing Approve button does not appear again for new swap after successful swap May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft Work in progress
Projects
None yet
Development

No branches or pull requests

1 participant