Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dapp, Runtime and Network #144

Closed
prayagd opened this issue May 15, 2023 · 8 comments · Fixed by #215
Closed

Fix Dapp, Runtime and Network #144

prayagd opened this issue May 15, 2023 · 8 comments · Fixed by #215

Comments

@prayagd
Copy link
Collaborator

prayagd commented May 15, 2023

Currently the DApp, Runtime and Network are confusing to the enduser. We are not aware what information is fetched here. So writing this ticket to make minor fixes.

Requirement

  • Remove Dapp
  • Keep Runtime
  • Change Network to Block no.
@prayagd
Copy link
Collaborator Author

prayagd commented May 15, 2023

Please add your planning poker estimate with Zenhub @gonzamontiel

@gonzamontiel
Copy link
Contributor

hey, sorry I think the description is not ready, I'm not able to estimate it @prayagd

@prayagd
Copy link
Collaborator Author

prayagd commented May 17, 2023

@gonzamontiel Hope this is clear now.

@gonzamontiel
Copy link
Contributor

So, updating on this:
DApp shows the result of api.rpc.system.name()
Runtime shows the result of api.rpc.system.version()

Lets use this ticket to define what to show to the user and under which label.

@erasmus
Copy link

erasmus commented Jun 1, 2023

We want to show to the end-user:

  • The last block (for liveness check/reference)
  • The current runtime version (for easy auditing -- they should be able to find the runtime version code on Github)
  • The current version of the Portal app (a unique ID that references the deployed state, for example, commit hash)

I think the first two are easy to include, while the third may require more work, and so could be moved to a separate Github issue.

@prayagd
Copy link
Collaborator Author

prayagd commented Jun 5, 2023

@gonzamontiel Do you agree to @erasmus suggestion here? Then will remove the third one and create a new one. So we can progress on this ticket.

@gonzamontiel
Copy link
Contributor

I agree with the described points. Also, for the third one, this is a value that we would like to generate, right? I don't know if that already exists. We have a tag system in CI that should increment the version inside package.json, but idk if this would be enough.
We can go ahead and redefine this ticket with the first two points.

@prayagd
Copy link
Collaborator Author

prayagd commented Jun 23, 2023

@gonzamontiel I have made the changes to the main description of this ticket. Regarding the Current version, we are now planning to have releases for the Portal and have release notes. On how to name them, lets sync on this in the weekly sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants