Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Inconvenience Compensation" in the reimburse dialog box. #104

Open
prayagd opened this issue Apr 20, 2023 · 4 comments
Open

Add "Inconvenience Compensation" in the reimburse dialog box. #104

prayagd opened this issue Apr 20, 2023 · 4 comments
Assignees
Labels

Comments

@prayagd
Copy link
Collaborator

prayagd commented Apr 20, 2023

As a spacewalk user, i should be able to see the compensation provided for failed redeem request when reimbursed

Acceptance criteria

  • Show "Inconvenience Compensation" under bridge fee in the reimburse dialog box
  • Show this amount in KSM/DOT(collateral asset)
@prayagd
Copy link
Collaborator Author

prayagd commented Apr 20, 2023

@gonzamontiel Would you need a design for this?

@prayagd
Copy link
Collaborator Author

prayagd commented Apr 21, 2023

Please add your planning poker estimate with Zenhub @gonzamontiel

@gonzamontiel
Copy link
Contributor

Where does this compensation come from? @ebma is this something that already comes in the request?

@ebma
Copy link
Member

ebma commented May 9, 2023

It's not included in the request, we need to calculate it. I briefly described it in this comment some time ago.

I would suggest we introduce hooks for price conversion into the code. These hooks would then either call the price conversion RPC calls of the oracle pallet or fetch the price from chain and do the calculations locally. (I assume calling the RPC functions is easier and would prefer using them).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants