Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug #21

Open
gstamp opened this issue May 25, 2016 · 1 comment
Open

Possible bug #21

gstamp opened this issue May 25, 2016 · 1 comment

Comments

@gstamp
Copy link

gstamp commented May 25, 2016

In the function req->token the single arity signature seems to be recursively calling itself
https://github.com/pelle/clauth/blob/master/src/clauth/middleware.clj#L38.

I think this is supposed to be calling into the 2 arity version. eg:

(defn req->token
  ([req]
   (req->token req token/find-valid-token))
  ([req finder]
   (if-let [token (req->token-string req)]
     (finder token))))
@gstamp
Copy link
Author

gstamp commented May 31, 2016

Also, this line in the middleware test case is referencing a function name as a key which I think is probably a typo.

https://github.com/pelle/clauth/blob/master/test/clauth/test/middleware.clj#L296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant