From 703e5480ff16e607a1314a06563b45765dd76a30 Mon Sep 17 00:00:00 2001 From: Boy132 Date: Mon, 13 May 2024 18:55:59 +0200 Subject: [PATCH] add missing fields to StoreScheduleRequest --- .../Api/Client/Servers/Schedules/StoreScheduleRequest.php | 2 ++ .../Api/Client/Server/Schedule/CreateServerScheduleTest.php | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/app/Http/Requests/Api/Client/Servers/Schedules/StoreScheduleRequest.php b/app/Http/Requests/Api/Client/Servers/Schedules/StoreScheduleRequest.php index 4537992e10..a74602ea12 100644 --- a/app/Http/Requests/Api/Client/Servers/Schedules/StoreScheduleRequest.php +++ b/app/Http/Requests/Api/Client/Servers/Schedules/StoreScheduleRequest.php @@ -19,9 +19,11 @@ public function rules(): array return [ 'name' => $rules['name'], 'is_active' => array_merge(['filled'], $rules['is_active']), + 'only_when_online' => $rules['only_when_online'], 'minute' => $rules['cron_minute'], 'hour' => $rules['cron_hour'], 'day_of_month' => $rules['cron_day_of_month'], + 'month' => $rules['cron_month'], 'day_of_week' => $rules['cron_day_of_week'], ]; } diff --git a/tests/Integration/Api/Client/Server/Schedule/CreateServerScheduleTest.php b/tests/Integration/Api/Client/Server/Schedule/CreateServerScheduleTest.php index 04c2a0ab65..a1939ea8f7 100644 --- a/tests/Integration/Api/Client/Server/Schedule/CreateServerScheduleTest.php +++ b/tests/Integration/Api/Client/Server/Schedule/CreateServerScheduleTest.php @@ -57,7 +57,7 @@ public function testScheduleValidationRules(): void $response = $this->actingAs($user)->postJson("/api/client/servers/$server->uuid/schedules", []); $response->assertStatus(Response::HTTP_UNPROCESSABLE_ENTITY); - foreach (['name', 'minute', 'hour', 'day_of_month', 'day_of_week'] as $i => $field) { + foreach (['name', 'minute', 'hour', 'day_of_month', 'month', 'day_of_week'] as $i => $field) { $response->assertJsonPath("errors.$i.code", 'ValidationException'); $response->assertJsonPath("errors.$i.meta.rule", 'required'); $response->assertJsonPath("errors.$i.meta.source_field", $field); @@ -67,6 +67,7 @@ public function testScheduleValidationRules(): void ->postJson("/api/client/servers/$server->uuid/schedules", [ 'name' => 'Testing', 'is_active' => 'no', + 'only_when_online' => 'false', 'minute' => '*', 'hour' => '*', 'day_of_month' => '*',