Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write special env variables at the very end of the installer #699

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Write special env variables at the very end of the installer #699

wants to merge 2 commits into from
+5 −2

Conversation

Boy132
Copy link
Member

@Boy132 Boy132 commented Nov 1, 2024

Closes #696

This makes sure that "special" env variables (in this case the SESSION_DRIVER) are only written to the .env file at the very end of the installer.
The SESSION_DRIVER variable is the only variable that directly affects the installer when being changed.

RMartinOscar
RMartinOscar requested changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@RMartinOscar RMartinOscar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

panel/app/Filament/Pages/Installer/PanelInstaller.php

Line 74 in 382dcb3

->hidden(fn (Get $get) => $get('env_general.SESSION_DRIVER') != 'redis' && $get('env_general.QUEUE_CONNECTION') != 'redis' && $get('env_general.CACHE_STORE') != 'redis'), 

->hidden(fn (Get $get) => $get('env_special.SESSION_DRIVER') != 'redis' && $get('env_general.QUEUE_CONNECTION') != 'redis' && $get('env_special.CACHE_STORE') != 'redis'),

panel/app/Filament/Pages/Installer/Steps/EnvironmentStep.php

Line 63 in 382dcb3

ToggleButtons::make('env_general.CACHE_STORE') 

ToggleButtons::make('env_special.CACHE_STORE')

We have to change those too

@Boy132
Copy link
Member Author

Boy132 commented Nov 1, 2024

panel/app/Filament/Pages/Installer/PanelInstaller.php

Line 74 in 382dcb3

->hidden(fn (Get $get) => $get('env_general.SESSION_DRIVER') != 'redis' && $get('env_general.QUEUE_CONNECTION') != 'redis' && $get('env_general.CACHE_STORE') != 'redis'), 

->hidden(fn (Get $get) => $get('env_special.SESSION_DRIVER') != 'redis' && $get('env_general.QUEUE_CONNECTION') != 'redis' && $get('env_special.CACHE_STORE') != 'redis'),

panel/app/Filament/Pages/Installer/Steps/EnvironmentStep.php

Line 63 in 382dcb3

ToggleButtons::make('env_general.CACHE_STORE') 

ToggleButtons::make('env_special.CACHE_STORE')

We have to change those too

Hidden check is fixed. And the cache driver is fine, it doesn't need special treatment.

@RMartinOscar
Copy link
Contributor

RMartinOscar commented Nov 1, 2024 •
edited
Loading

I had the same 500 as before when hitting next in the db step with redis selected as cache store it errors immediately i can't even fill in the redis host & pass so it uses no password cause no redis env is set yet.
This is fixed with my proposed changes.

Using redis which is on something else but localhost will also throw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RMartinOscar RMartinOscar RMartinOscar requested changes

@lancepioch lancepioch Awaiting requested review from lancepioch

Requested changes must be addressed to merge this pull request.

Assignees

@Boy132 Boy132

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Installer] Database type should not be persisted until after all the db info is submitted
2 participants
@Boy132 @RMartinOscar