Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleted Webhook still triggers #689

Open
RMartinOscar opened this issue Oct 29, 2024 · 0 comments · May be fixed by #695
Open

Deleted Webhook still triggers #689

RMartinOscar opened this issue Oct 29, 2024 · 0 comments · May be fixed by #695
Assignees
@lancepioch
Labels
🐛 bug Something isn't working 🟢 easy Good for newcomers
Milestone
beta12

Comments

@RMartinOscar
Copy link
Contributor

I think its due to forever caching

panel/app/Models/WebhookConfiguration.php

Line 44 in 3f9c1db

cache()->forever("webhooks.$event", WebhookConfiguration::query()->whereJsonContains('events', $event)->get());

panel/app/Listeners/DispatchWebhooks.php

Line 16 in 3f9c1db

$matchingHooks = cache()->rememberForever("webhooks.$eventName", function () use ($eventName) {

@RMartinOscar RMartinOscar added 🐛 bug Something isn't working 🟢 easy Good for newcomers labels Oct 29, 2024
@RMartinOscar RMartinOscar added this to the beta12 milestone Oct 29, 2024
@lancepioch lancepioch linked a pull request Oct 31, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lancepioch lancepioch

Labels
🐛 bug Something isn't working 🟢 easy Good for newcomers
Projects
None yet
Milestone
beta12
Development

Successfully merging a pull request may close this issue.

Clear webhook cache when webhooks are deleted vehikl/pelican-panel
2 participants
@lancepioch @RMartinOscar