Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Node Health not live & Add tooltip #687

Merged
merged 6 commits into from
Oct 30, 2024

Conversation

RMartinOscar
Copy link
Contributor

@RMartinOscar RMartinOscar commented Oct 29, 2024

  • Add livewire poll so it auto refresh
  • Add back version tooltip

image
image

@RMartinOscar RMartinOscar self-assigned this Oct 29, 2024
@RMartinOscar RMartinOscar modified the milestone: beta12 Oct 29, 2024
@RMartinOscar RMartinOscar added the 🐛 bug Something isn't working label Oct 29, 2024
@Boy132
Copy link
Member

Boy132 commented Oct 29, 2024

Nothing is shown on hover if the node is offline should i add a Unknown ?

Yes, something similar to the tooltip from the old admin area.

We should also lower the refresh rate to 5 seconds (or maybe 10 or 15 even?)

@RMartinOscar
Copy link
Contributor Author

image
image

Maybe its a bit long ?

I searched for a way to define $pollingInterval in php but it didn't care so i hardcoded it in the blade

@Boy132
Copy link
Member

Boy132 commented Oct 29, 2024

image image

Maybe its a bit long ?

Is there a way to add a line break?

@RMartinOscar
Copy link
Contributor Author

Is there a way to add a line break?

I tried without success

@Boy132
Copy link
Member

Boy132 commented Oct 29, 2024

On a second thought, do we even print errors to the browser console?

@RMartinOscar
Copy link
Contributor Author

RMartinOscar commented Oct 29, 2024

On a second thought, do we even print errors to the browser console?

LMAO we don't and there's nothing but 200 in the network tab too; should i set it to Error connecting to node! ?

app/Models/Node.php Outdated Show resolved Hide resolved
app/Models/Node.php Outdated Show resolved Hide resolved
app/Models/Node.php Outdated Show resolved Hide resolved
@RMartinOscar RMartinOscar merged commit e717e20 into pelican-dev:main Oct 30, 2024
15 checks passed
@RMartinOscar RMartinOscar deleted the fix/HealthVersion branch October 30, 2024 00:58
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node Health Status doesn't auto refresh & Version tooltip not showing
3 participants