You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently round ends on timeout or when all players made their turn.
It's quite common for newcomers to drop off the game, hence we would like to modify current logic so that
By default when game starts all players are flagged active
If player did not made any activity previous round, he is flagged as idle
Early turn ending is possible if all active members made their move.
If player made a move and playerMove is called, player must be set back to active
In LibQuadraticVotingfunction computeScoresByVPIndex should take in list of whether participant proposed or not (infer from is active or not). If is true, the Gives benefits to everyone but himself action must be bypassed.
Flag can be added to LibTurnBasedGame.sol -> struct GameInstance.
The check for early ending can be added to LibTurnBasedGame -> struct canEndTurnEarly
Write additional tests:
test/RankifyInstance.ts:
When first turn was made:
Does not wait for a participant who did not made a move in previous turn
When second turn was made:
Waits for participant who was idle and made a move in last finalised turn
Idle participant did not give points during end turn score calculation
Idle participant who became active gives a proper scores
The text was updated successfully, but these errors were encountered:
Currently round ends on timeout or when all players made their turn.
It's quite common for newcomers to drop off the game, hence we would like to modify current logic so that
active
idle
active
members made their move.playerMove
is called, player must be set back toactive
LibQuadraticVoting
function computeScoresByVPIndex
should take in list of whether participant proposed or not (infer from is active or not). If is true, theGives benefits to everyone but himself
action must be bypassed.Flag can be added to
LibTurnBasedGame.sol -> struct GameInstance
.The check for early ending can be added to
LibTurnBasedGame -> struct canEndTurnEarly
Write additional tests:
test/RankifyInstance.ts
:When first turn was made:
When second turn was made:
The text was updated successfully, but these errors were encountered: