Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate keys from props #17

Open
harrim91 opened this issue Jun 20, 2020 · 1 comment
Open

Separate keys from props #17

harrim91 opened this issue Jun 20, 2020 · 1 comment
Labels
enhancement New feature or request feature_request help wanted Extra attention is needed

Comments

@harrim91
Copy link
Contributor

This one is open for debate and would be a big change.

There are lots of areas where it would be helpful to separate out the key schemas of a table from the rest of the attributes.

Once an item is saved in the database, its key shouldn't change - If you call put with a different key, it will create a new item, which is probably not what you want a lot of the time. You can't call update with key properties - you need to specify the key in one parameter and the values to change in another. I think we should reflect this logic separation.

A big reason for doing this would be to better support single-table design. If you do this properly, the key is kind of distinct from the actual data anyway - see this video for more info on what I mean here

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.90. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@harrim91 harrim91 added enhancement New feature or request help wanted Extra attention is needed labels Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature_request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant