Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring Decl'HDF5 compatibility tests #498

Open
jmorice91 opened this issue Nov 18, 2024 · 0 comments
Open

Refactoring Decl'HDF5 compatibility tests #498

jmorice91 opened this issue Nov 18, 2024 · 0 comments
Labels
module: decl'hdf5 request:: testing

Comments

@jmorice91
Copy link
Contributor

jmorice91 commented Nov 18, 2024 •
edited
Loading

Ideally, we'd like to handle these differently.

Whatever the way the data is written, with MPI or not it should be compatible at the end. I believe they'd better fit at the same level as HDF5_C_ and PDI_C_ rather than the test name.

In this PR, I think what's there already can be used, but please make an issue about this.

Originally posted by @jbigot in #494 (comment)

I believe the compatibility tests should be reworked, but this is a big work and deserves its own issue & PR

Originally posted by @jbigot in #494 (review)
@jmorice91 jmorice91 changed the title Looks good. A few changes and it should be good to go. refactoring of the compatibility test Nov 18, 2024
@jbigot jbigot changed the title refactoring of the compatibility test Refactoring Decl'HDF5 compatibility test Nov 18, 2024
@jbigot jbigot changed the title Refactoring Decl'HDF5 compatibility test Refactoring Decl'HDF5 compatibility tests Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: decl'hdf5 request:: testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbigot @jmorice91