From 31f568535680a9a61dff2d7e12115e2b7cfb294c Mon Sep 17 00:00:00 2001 From: Zachary Lentz Date: Fri, 15 Mar 2024 11:52:36 -0700 Subject: [PATCH 1/2] DOC: add checklist item for checking dry run before future PRs --- .github/pull_request_template.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 6606661..f247a5d 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -21,6 +21,7 @@ ## Pre-merge checklist - [ ] Code works interactively +- [ ] Code works interactively in dry_run mode - [ ] Code contains descriptive docstrings, including context and API - [ ] Pre-commit passes on GitHub Actions - [ ] Documentation under https://confluence.slac.stanford.edu/display/PCDS/TcBSD has been updated appropriately From 951973961d0a57c50b20cdb85106cd36675c4814 Mon Sep 17 00:00:00 2001 From: Zachary Lentz Date: Fri, 15 Mar 2024 11:53:04 -0700 Subject: [PATCH 2/2] FIX: allow provisioning playbook to skip config check in dry run --- tcbsd-provision-playbook.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/tcbsd-provision-playbook.yaml b/tcbsd-provision-playbook.yaml index a58ef38..93c4bc7 100644 --- a/tcbsd-provision-playbook.yaml +++ b/tcbsd-provision-playbook.yaml @@ -12,6 +12,7 @@ cmd: TcSysExe.exe --mode - name: Assert that PLC is in CONFIG mode + when: not ansible_check_mode ansible.builtin.assert: that: "{{ 'CONFIG' in plc_mode.stdout }}" fail_msg: "PLC is in RUN mode! Abort!"