Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: handle tags in NameDescTagsWidget #92

Open
tangkong opened this issue Oct 10, 2024 · 0 comments
Open

GUI: handle tags in NameDescTagsWidget #92

tangkong opened this issue Oct 10, 2024 · 0 comments

Comments

@tangkong
Copy link
Contributor

Current Behavior

Currently, if you try to add a tag, the app will crash.

Expected Behavior

We should be able to add tags

Context / environment

This requires us to actually implement tags on the client side as well. A few things need to be done specifically on the GUI side:

  • Adjust TagsWidget to expect the dataclass field to be a set, not a list. This is easy enough to do, updates will probably have to just re-create the set every time the tags are updated
  • Ensure these tags match the permitted Tag class members (these are Flags), and make sure they serialize correctly

unearthed in #90

Steps to Reproduce (for bugs)

  1. Open a Page (collection builder page, for example)
  2. Click the "+" button to add a tag
  3. 💥

Suggested Solution

See context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant