Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: allow user-specified sort order of grid rows and columns #106

Open
klauer opened this issue Aug 2, 2022 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@klauer
Copy link
Contributor

klauer commented Aug 2, 2022

Issue

Currently, the rows and columns in the device overview grid are sorted alphabetically.

In order to rearrange the order, the user has to take care to change the functional/location group in the happi database just to change the home display. This can include making arbitrary values for these fields just to make them in alphabetical order.

Configuration settings as in master

Right now, we have configuration settings:

  • Passed as command-line parameters
    • Toolbar location
    • Row group key
    • Column group key
    • Log level
    • Dark colorscheme
  • Toolbar
    • Stored in a separate file, pointed to by command-line parameter
    • These toolbar configurations are fortunately named a very specific {hutch}_toolbar.yml

Simplest proposal

An easier solution with less refactoring could include just:

  • Two new command-line parameters that set the sort order of rows/columns

If we're to take it on, I think it's worth looking at a different option (next section).

Ideal proposal

I think that the separation of command-line parameter vs configuration-file specified parameters is a bit haphazard.
I would suggest:

  • Add a top-level configuration file to LUCID that contains all command-line parameter settings
  • The toolbar settings could be wrapped into the overall settings or remain separate
  • Add a grid configuration setting
    • Row group key
    • Column group key
    • Row group order
    • Column group order

Rows/columns not in the list would be added in alphabetical order at the end of the grid.

@klauer klauer added the enhancement New feature or request label Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant