Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoiding dev/prod conflicts of device definitions #42

Open
klauer opened this issue Sep 6, 2023 · 0 comments
Open

Avoiding dev/prod conflicts of device definitions #42

klauer opened this issue Sep 6, 2023 · 0 comments

Comments

@klauer
Copy link
Contributor

klauer commented Sep 6, 2023

Issue

Per @ZLLentz:

I wonder if there's any way to avoid this problem:

  1. A new class is added to pcdsdevices
  2. happi is updated to expect the new class
  3. All old code that referenced this device needs a pcdsdevices update or the load fails

It makes me wonder if we need to do versioning on these or have some other way to maintain backward compatibility in this sort of environment...

Originally posted by @ZLLentz in #41 (comment)

Possibilities

Our thoughts for avoiding this:

  1. Device-specific classes as in AT1K4 with helpful docstrings (@klauer)
  2. Factory methods for creating devices (@tangkong)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant