Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up a few things to get rid of Warnings #56

Open
7 of 8 tasks
andrew-edwards opened this issue Apr 24, 2024 · 3 comments
Open
7 of 8 tasks

Clean up a few things to get rid of Warnings #56

andrew-edwards opened this issue Apr 24, 2024 · 3 comments
Assignees

Comments

@andrew-edwards
Copy link
Member

andrew-edwards commented Apr 24, 2024

From R-CMD-check (online, linked from checkmark next to commit), fix some Warnings:

  • Warning: '::' or ':::' import not declared from: ‘tibble’
  • Warning: Invalid license file pointers: LICENSE

Undocumented data sets:

Recent commit should fix this one, just a missing s in clim_anom() help:

  • clim_years
  • clim_year [not in \usage]

plot_with_uncertainty_discrete:

  • y_tick undocumented
@travistai2
Copy link
Contributor

I'm not sure if 'test_grid_20' was used anywhere - I didn't use it.

@andrew-edwards
Copy link
Member Author

Yes, I think I got rid of it (hence the box was ticked). Sorry, that wasn't obvious.

@andrew-edwards
Copy link
Member Author

  • Also this one https://github.com/pbs-assess/pacea/actions/runs/8841447116/job/24278561740#step:5:98 about adding ... to plot.XXX() functions. We hadn't included them because they call ggplot functions not base plot. However, I think it's okay to add them in (but not pass them onto anything), as as is done in ggplot itself (?ggplot). Trying one first to see if it changes the warning, but the warning isn't really specific about a particular function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants