Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlainMaskedConv2d does not handle connections between color channels #1

Open
ethanjyx opened this issue Jun 10, 2020 · 1 comment
Open

Comments

@ethanjyx
Copy link

Hi there, I am trying to get the simple PixelCNN model working on CIFAR10, I took a look at your implementation here https://github.com/pbloem/pixel-models/blob/master/layers.py#L8-L32, and it looks like the masks are only on pixels, but there are no masks among RGB values, is this correct?

@pbloem
Copy link
Owner

pbloem commented Jun 12, 2020

Hi, as far as I remember, the plain version you link to doesn't have connections between color values. This means it predicts each color independently from what it predicts for the other colors. This makes it a much simpler in implementation, but much less powerful than a model that conditions each color on the previous one.

The MaskedConv2d and its two conditional versions do this, but they're a bit more complicated as a result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants